[PR #393] [MERGED] Go PRs standards audit #496

New issue

Closed

opened 2026-02-26 22:31:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/393
Author: @rudrankriyam
Created: 2/1/2026
Status: ✅ Merged
Merged: 2/1/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/go-prs-standards-audit-3e96

📝 Commits (10+)

23a46ee Add content rights declaration support to apps update command
6917cc8 Add review submissions-cancel command to cancel draft submissions
398ad34 Show usesNonExemptEncryption in builds list output
43b5c7f Add app-infos list command to show app info IDs
5b21e7d Add --pkg flag to builds upload for macOS apps
4a16a34 Add app-infos and review cancel validations
bdbdbe8 Merge PR 388: content rights declaration
a206a37 Merge PR 389: review submissions cancel
d70fd30 Merge PR 390: build encryption status
e1659b3 Merge PR 391: app-infos list

📊 Changes

11 files changed (+436 additions, -44 deletions)

View changed files

📝 internal/asc/client_apps.go (+17 -7)
📝 internal/asc/client_builds.go (+1 -1)
📝 internal/asc/client_types.go (+1 -0)
📝 internal/asc/output_builds.go (+20 -5)
➕ internal/cli/apps/app_infos.go (+88 -0)
📝 internal/cli/apps/apps.go (+19 -6)
📝 internal/cli/builds/builds_commands.go (+83 -23)
📝 internal/cli/cmdtest/commands_test.go (+158 -2)
📝 internal/cli/registry/registry.go (+1 -0)
📝 internal/cli/reviews/review.go (+1 -0)
📝 internal/cli/reviews/review_submissions.go (+47 -0)

📄 Description

Add missing CLI validation and tests for app-infos list, apps update --content-rights, and review submissions-cancel commands to comply with Go standards and API notes.

These changes were identified during an audit of several open PRs (391, 388, 389) against docs/GO_STANDARDS.md and docs/API_NOTES.md, primarily focusing on ensuring comprehensive CLI validation and test coverage.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/393 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/1/2026 **Status:** ✅ Merged **Merged:** 2/1/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/go-prs-standards-audit-3e96` --- ### 📝 Commits (10+) - [`23a46ee`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/23a46ee464bbe176677d32a9a29967252fc5d3cb) Add content rights declaration support to apps update command - [`6917cc8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/6917cc849247f28b5dfbbd14d881627d3ed44ca5) Add review submissions-cancel command to cancel draft submissions - [`398ad34`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/398ad3414c3d658240fd097518c058b7f0fafb94) Show usesNonExemptEncryption in builds list output - [`43b5c7f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/43b5c7f3e38dc20229da798f544c79f571a9ef87) Add app-infos list command to show app info IDs - [`5b21e7d`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/5b21e7d1294d2f4640663a85519d9aa23ed42553) Add --pkg flag to builds upload for macOS apps - [`4a16a34`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4a16a34285a9503c93035ec904da529da5c45d71) Add app-infos and review cancel validations - [`bdbdbe8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/bdbdbe871cdbc6df0928c1dc4a1267c41b2a3f7e) Merge PR 388: content rights declaration - [`a206a37`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a206a37cafaffdd0bf6a9234645c3d9f49f3cfcc) Merge PR 389: review submissions cancel - [`d70fd30`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/d70fd302216d6b7a9e0ecf9b228eef47f0ab302e) Merge PR 390: build encryption status - [`e1659b3`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/e1659b340a5b6d50f360dd131b0c21e8d419f3f9) Merge PR 391: app-infos list ### 📊 Changes **11 files changed** (+436 additions, -44 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_apps.go` (+17 -7) 📝 `internal/asc/client_builds.go` (+1 -1) 📝 `internal/asc/client_types.go` (+1 -0) 📝 `internal/asc/output_builds.go` (+20 -5) ➕ `internal/cli/apps/app_infos.go` (+88 -0) 📝 `internal/cli/apps/apps.go` (+19 -6) 📝 `internal/cli/builds/builds_commands.go` (+83 -23) 📝 `internal/cli/cmdtest/commands_test.go` (+158 -2) 📝 `internal/cli/registry/registry.go` (+1 -0) 📝 `internal/cli/reviews/review.go` (+1 -0) 📝 `internal/cli/reviews/review_submissions.go` (+47 -0) </details> ### 📄 Description Add missing CLI validation and tests for `app-infos list`, `apps update --content-rights`, and `review submissions-cancel` commands to comply with Go standards and API notes. These changes were identified during an audit of several open PRs (391, 388, 389) against `docs/GO_STANDARDS.md` and `docs/API_NOTES.md`, primarily focusing on ensuring comprehensive CLI validation and test coverage. --- <a href="https://cursor.com/background-agent?bcId=bc-f17af80f-70a6-4295-9882-6c056dbbdbd2"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img alt="Open in Cursor" width="131" height="28" src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> <a href="https://cursor.com/agents?id=bc-f17af80f-70a6-4295-9882-6c056dbbdbd2"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/assets/images/open-in-web-light.png"><img alt="Open in Web" width="114" height="28" src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>