[PR #410] [MERGED] Enabled versions output validation #506

Closed
opened 2026-02-26 22:31:16 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/410
Author: @cursor[bot]
Created: 2/2/2026
Status: Merged
Merged: 2/2/2026
Merged by: @rudrankriyam

Base: mainHead: cursor/enabled-versions-output-validation-7948


📝 Commits (1)

  • 5e969de Remove redundant enabled-versions output validation

📊 Changes

2 files changed (+4 additions, -42 deletions)

View changed files

📝 internal/cli/cmdtest/testflight_metrics_beta_tester_usages_test.go (+0 -6)
📝 internal/cli/gamecenter/game_center_enabled_versions.go (+4 -36)

📄 Description

Remove redundant output normalization function to leverage shared printOutput logic.

The normalizeEnabledVersionsOutput function duplicated validation and formatting logic already handled by shared.PrintOutput, leading to redundant code and inconsistency with other commands in the package.



🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/410 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 2/2/2026 **Status:** ✅ Merged **Merged:** 2/2/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/enabled-versions-output-validation-7948` --- ### 📝 Commits (1) - [`5e969de`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/5e969ded87ee0d8cf88236854b367853b1e4d3a6) Remove redundant enabled-versions output validation ### 📊 Changes **2 files changed** (+4 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `internal/cli/cmdtest/testflight_metrics_beta_tester_usages_test.go` (+0 -6) 📝 `internal/cli/gamecenter/game_center_enabled_versions.go` (+4 -36) </details> ### 📄 Description Remove redundant output normalization function to leverage shared `printOutput` logic. The `normalizeEnabledVersionsOutput` function duplicated validation and formatting logic already handled by `shared.PrintOutput`, leading to redundant code and inconsistency with other commands in the package. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 22:31:16 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/App-Store-Connect-CLI#506
No description provided.