[PR #506] [MERGED] Surface associatedErrors in API error output #579

New issue

Closed

opened 2026-02-26 22:31:37 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:31:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/506
Author: @rudrankriyam
Created: 2/11/2026
Status: ✅ Merged
Merged: 2/11/2026
Merged by: @rudrankriyam

Base: main ← Head: feat/apps-showcase-community-wall

📝 Commits (4)

b042a37 Surface App Store Connect associated errors in CLI output.
189cd59 Add API error fixture intake docs and issue form.
501effe Add foundation-models fixture intake scaffolding.
af32447 Remove API error fixture scaffolding artifacts.

📊 Changes

5 files changed (+356 additions, -16 deletions)

View changed files

📝 internal/asc/client_http.go (+66 -7)
📝 internal/asc/client_test.go (+94 -0)
📝 internal/asc/errors.go (+69 -9)
📝 internal/asc/errors_test.go (+36 -0)
➕ internal/cli/cmdtest/review_items_associated_errors_test.go (+91 -0)

📄 Description

Summary

Parse errors[].meta.associatedErrors from App Store Connect error responses and preserve actionable details on APIError.
Include associated errors in rendered CLI error messages with deterministic resource ordering and existing terminal sanitization.
Add regression coverage for parser behavior (including malformed associatedErrors) and review items-add error surfacing.

Test plan

make format
make lint
make test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/506 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 2/11/2026 **Status:** ✅ Merged **Merged:** 2/11/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `feat/apps-showcase-community-wall` --- ### 📝 Commits (4) - [`b042a37`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/b042a375f5f31e80448b2884ab0bb657ed6ebce6) Surface App Store Connect associated errors in CLI output. - [`189cd59`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/189cd59ef598940d1ac34982c245634af54c14c9) Add API error fixture intake docs and issue form. - [`501effe`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/501effe74bc611020c270f2764907ad1c0b072e8) Add foundation-models fixture intake scaffolding. - [`af32447`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/af32447f9e206ae021f4f0bdc6bdc7d2cde90749) Remove API error fixture scaffolding artifacts. ### 📊 Changes **5 files changed** (+356 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `internal/asc/client_http.go` (+66 -7) 📝 `internal/asc/client_test.go` (+94 -0) 📝 `internal/asc/errors.go` (+69 -9) 📝 `internal/asc/errors_test.go` (+36 -0) ➕ `internal/cli/cmdtest/review_items_associated_errors_test.go` (+91 -0) </details> ### 📄 Description ## Summary - Parse `errors[].meta.associatedErrors` from App Store Connect error responses and preserve actionable details on `APIError`. - Include associated errors in rendered CLI error messages with deterministic resource ordering and existing terminal sanitization. - Add regression coverage for parser behavior (including malformed associatedErrors) and `review items-add` error surfacing. ## Test plan - [x] `make format` - [x] `make lint` - [x] `make test` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>