[PR #284] [MERGED] Keychain default credentials #410

New issue

Closed

opened 2026-02-26 22:30:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:30:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/284
Author: @cursor[bot]
Created: 1/29/2026
Status: ✅ Merged
Merged: 1/29/2026
Merged by: @rudrankriyam

Base: fix/default-profile-config ← Head: cursor/keychain-default-credentials-762d

📝 Commits (1)

8403bd8 Fix default credential lookup

📊 Changes

1 file changed (+13 additions, -14 deletions)

View changed files

📝 internal/auth/keychain.go (+13 -14)

📄 Description

Refactor default credential lookup to pass the correct key to getCredentialsFromConfig and avoid duplicate defaultName() calls.

The original implementation for default key handling in GetCredentialsWithSource had two issues: it passed an empty profile to getCredentialsFromConfig even when a defaultKey was identified, relying on an internal fallback; and it redundantly called defaultName() (which loads config) twice in the same path. This fix addresses both by resolving the default key once at the start of GetCredentialsWithSource and using it consistently.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/284 **Author:** [@cursor[bot]](https://github.com/apps/cursor) **Created:** 1/29/2026 **Status:** ✅ Merged **Merged:** 1/29/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `fix/default-profile-config` ← **Head:** `cursor/keychain-default-credentials-762d` --- ### 📝 Commits (1) - [`8403bd8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/8403bd8e99add366647f0aa4ed0c130818341c3e) Fix default credential lookup ### 📊 Changes **1 file changed** (+13 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `internal/auth/keychain.go` (+13 -14) </details> ### 📄 Description Refactor default credential lookup to pass the correct key to `getCredentialsFromConfig` and avoid duplicate `defaultName()` calls. The original implementation for default key handling in `GetCredentialsWithSource` had two issues: it passed an empty `profile` to `getCredentialsFromConfig` even when a `defaultKey` was identified, relying on an internal fallback; and it redundantly called `defaultName()` (which loads config) twice in the same path. This fix addresses both by resolving the default key once at the start of `GetCredentialsWithSource` and using it consistently. --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>