[PR #100] [MERGED] Build upload full flow #284

New issue

Closed

opened 2026-02-26 21:34:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 21:34:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/100
Author: @rudrankriyam
Created: 1/24/2026
Status: ✅ Merged
Merged: 1/24/2026
Merged by: @rudrankriyam

Base: main ← Head: cursor/build-upload-full-flow-06db

📝 Commits (10+)

3febac8 Add build upload execution and checksum verification
ea0e747 Fix upload job dispatch cancellation
688ce39 Prevent upload job dispatch deadlock
95a577e Make builds upload run by default
093b64d Fix build upload State type and handle empty checksums gracefully
64da82f Add regression test for upload dispatch cancellation.
4ab5a64 Merge pull request #121 from rudrankriyam/fix/build-upload-improvements
3741552 Merge pull request #115 from rudrankriyam/cursor/upload-channel-deadlock-d33b
81253ef Remove unused upload retry option
a442fcd Merge pull request #126 from rudrankriyam/cursor/unused-upload-retry-option-00a3

📊 Changes

10 files changed (+724 additions, -28 deletions)

View changed files

📝 Agents.md (+2 -0)
📝 README.md (+2 -0)
📝 cmd/builds_commands.go (+80 -5)
📝 cmd/shared.go (+7 -0)
📝 internal/asc/client_builds.go (+5 -5)
📝 internal/asc/client_core.go (+14 -3)
📝 internal/asc/output_builds.go (+42 -15)
📝 internal/asc/output_test.go (+27 -0)
➕ internal/asc/upload.go (+265 -0)
➕ internal/asc/upload_test.go (+280 -0)

📄 Description

Completes the App Store Connect build upload flow by adding actual file upload, checksum verification, and commit functionality.

The existing builds upload command only handled the reservation of upload slots. This PR implements the missing steps: executing PUT requests to the presigned URLs, computing and optionally verifying file checksums, and calling UpdateBuildUploadFile to commit the upload to App Store Connect, enabling a full end-to-end build upload directly from the CLI.

Fixes #78

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/100 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/24/2026 **Status:** ✅ Merged **Merged:** 1/24/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `cursor/build-upload-full-flow-06db` --- ### 📝 Commits (10+) - [`3febac8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3febac8768e53214348b1d01807a76ab963c0633) Add build upload execution and checksum verification - [`ea0e747`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/ea0e74770a25d21ef9ce1cd51dcbe10b3b8ac088) Fix upload job dispatch cancellation - [`688ce39`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/688ce39d8af46bbb8eb2f90ff1fab0af6904bf8d) Prevent upload job dispatch deadlock - [`95a577e`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/95a577e7907a6a22d93aac12dee20b6c89fde061) Make builds upload run by default - [`093b64d`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/093b64d272032c874233d8f0fe1568c8d06c164d) Fix build upload State type and handle empty checksums gracefully - [`64da82f`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/64da82fdeb0f256448bfeff00e81c0ec26ec332d) Add regression test for upload dispatch cancellation. - [`4ab5a64`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/4ab5a6418ad9f0a2ff35b8a4cc2f651da65785e8) Merge pull request #121 from rudrankriyam/fix/build-upload-improvements - [`3741552`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/3741552bb47230fd9865e2f7f6b5a05302dcbca5) Merge pull request #115 from rudrankriyam/cursor/upload-channel-deadlock-d33b - [`81253ef`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/81253ef03dfcc5e51b6ff3e11a85c7db891e790e) Remove unused upload retry option - [`a442fcd`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/a442fcde931c0bb1248d50636fd9296ebddf2d9c) Merge pull request #126 from rudrankriyam/cursor/unused-upload-retry-option-00a3 ### 📊 Changes **10 files changed** (+724 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `Agents.md` (+2 -0) 📝 `README.md` (+2 -0) 📝 `cmd/builds_commands.go` (+80 -5) 📝 `cmd/shared.go` (+7 -0) 📝 `internal/asc/client_builds.go` (+5 -5) 📝 `internal/asc/client_core.go` (+14 -3) 📝 `internal/asc/output_builds.go` (+42 -15) 📝 `internal/asc/output_test.go` (+27 -0) ➕ `internal/asc/upload.go` (+265 -0) ➕ `internal/asc/upload_test.go` (+280 -0) </details> ### 📄 Description Completes the App Store Connect build upload flow by adding actual file upload, checksum verification, and commit functionality. The existing `builds upload` command only handled the reservation of upload slots. This PR implements the missing steps: executing PUT requests to the presigned URLs, computing and optionally verifying file checksums, and calling `UpdateBuildUploadFile` to commit the upload to App Store Connect, enabling a full end-to-end build upload directly from the CLI. --- <a href="https://cursor.com/background-agent?bcId=bc-ed6cd6a7-9bd9-4d0e-bd20-8a3e6f00abec"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-cursor-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-cursor-light.svg"><img alt="Open in Cursor" src="https://cursor.com/open-in-cursor.svg"></picture></a> <a href="https://cursor.com/agents?id=bc-ed6cd6a7-9bd9-4d0e-bd20-8a3e6f00abec"><picture><source media="(prefers-color-scheme: dark)" srcset="https://cursor.com/open-in-web-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://cursor.com/open-in-web-light.svg"><img alt="Open in Web" src="https://cursor.com/open-in-web.svg"></picture></a> Fixes #78 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>