[PR #282] [MERGED] fix: honor config default with keychain creds #406

New issue

Closed

opened 2026-02-26 22:30:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 22:30:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/282
Author: @rudrankriyam
Created: 1/29/2026
Status: ✅ Merged
Merged: 1/29/2026
Merged by: @rudrankriyam

Base: main ← Head: fix/default-profile-config

📝 Commits (3)

efed289 fix: honor config default with keychain creds
8403bd8 Fix default credential lookup
9cddc81 Merge pull request #284 from rudrankriyam/cursor/keychain-default-credentials-762d

📊 Changes

2 files changed (+54 additions, -18 deletions)

View changed files

📝 internal/auth/keychain.go (+18 -18)
📝 internal/auth/keychain_test.go (+36 -0)

📄 Description

Summary

honor config default credentials when keychain has other entries
avoid auto-selecting a sole keychain credential if a default name is set
add coverage for config-default fallback

Test plan

go test ./internal/auth

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rudrankriyam/App-Store-Connect-CLI/pull/282 **Author:** [@rudrankriyam](https://github.com/rudrankriyam) **Created:** 1/29/2026 **Status:** ✅ Merged **Merged:** 1/29/2026 **Merged by:** [@rudrankriyam](https://github.com/rudrankriyam) **Base:** `main` ← **Head:** `fix/default-profile-config` --- ### 📝 Commits (3) - [`efed289`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/efed289a9f6be7f6c570ab4599862507f6385d5f) fix: honor config default with keychain creds - [`8403bd8`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/8403bd8e99add366647f0aa4ed0c130818341c3e) Fix default credential lookup - [`9cddc81`](https://github.com/rudrankriyam/App-Store-Connect-CLI/commit/9cddc814fb74d0127289e8238c5aedfe862d1db0) Merge pull request #284 from rudrankriyam/cursor/keychain-default-credentials-762d ### 📊 Changes **2 files changed** (+54 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `internal/auth/keychain.go` (+18 -18) 📝 `internal/auth/keychain_test.go` (+36 -0) </details> ### 📄 Description ## Summary - honor config default credentials when keychain has other entries - avoid auto-selecting a sole keychain credential if a default name is set - add coverage for config-default fallback ## Test plan - [x] go test ./internal/auth --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>