[PR #700] [MERGED] fix(setup): Use resolve() before invoking as_uri() #711

New issue

Closed

opened 2026-02-27 23:02:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 23:02:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/sigma67/ytmusicapi/pull/700
Author: @apastel
Created: 12/22/2024
Status: ✅ Merged
Merged: 12/27/2024
Merged by: @sigma67

Base: main ← Head: patch-1

📝 Commits (1)

19ce896 fix(setup): Use resolve() before invoking as_uri()

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 ytmusicapi/setup.py (+1 -1)

📄 Description

If no --file argument is provided to setup, as_uri() throws a ValueError when it tries to get the relative path to print to the console. Using resolve() will work in both case (--file provided or not provided).

Fixes #699

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/sigma67/ytmusicapi/pull/700 **Author:** [@apastel](https://github.com/apastel) **Created:** 12/22/2024 **Status:** ✅ Merged **Merged:** 12/27/2024 **Merged by:** [@sigma67](https://github.com/sigma67) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`19ce896`](https://github.com/sigma67/ytmusicapi/commit/19ce8969caffadc8f76bedb3457275dca76bdea8) fix(setup): Use resolve() before invoking as_uri() ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `ytmusicapi/setup.py` (+1 -1) </details> ### 📄 Description If no `--file` argument is provided to setup, `as_uri()` throws a ValueError when it tries to get the relative path to print to the console. Using `resolve()` will work in both case (`--file` provided or not provided). Fixes #699 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>