[PR #678] [MERGED] search: adds functionality to remove search suggestion #699

Closed
opened 2026-02-27 23:02:03 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/sigma67/ytmusicapi/pull/678
Author: @comarquet
Created: 11/13/2024
Status: Merged
Merged: 12/17/2024
Merged by: @sigma67

Base: mainHead: main


📝 Commits (6)

  • 2d52e04 search: adds functionality to remove search history suggestion
  • 1da1967 Minor improvements for remove search suggestions
  • 808077b fix lint
  • 9d65260 Merge remote-tracking branch 'origin/main' into comarquet-main
  • aa3a41f some improvements: remove_search_suggestions
  • 4801d3a make indices optional

📊 Changes

4 files changed (+110 additions, -12 deletions)

View changed files

📝 docs/source/reference.rst (+2 -0)
📝 tests/mixins/test_search.py (+29 -0)
📝 ytmusicapi/mixins/search.py (+60 -7)
📝 ytmusicapi/parsers/search.py (+19 -5)

📄 Description

Related to #497

I modified parse_search_suggestions so that it retrieves the feedbackToken of each suggestion in the search bar and associates it with the number it is displayed when invoking get_search_suggestions, so that the function remove_search_suggestion can be called with the number as parameter to delete the corresponding entry.

image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sigma67/ytmusicapi/pull/678 **Author:** [@comarquet](https://github.com/comarquet) **Created:** 11/13/2024 **Status:** ✅ Merged **Merged:** 12/17/2024 **Merged by:** [@sigma67](https://github.com/sigma67) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (6) - [`2d52e04`](https://github.com/sigma67/ytmusicapi/commit/2d52e047013a352f56c991a6e0799b52929d8f34) search: adds functionality to remove search history suggestion - [`1da1967`](https://github.com/sigma67/ytmusicapi/commit/1da196748f94b193c4628a7dd27c63c5b0f90b5e) Minor improvements for remove search suggestions - [`808077b`](https://github.com/sigma67/ytmusicapi/commit/808077ba256b006e52b091e3b77bd5aeab00a82e) fix lint - [`9d65260`](https://github.com/sigma67/ytmusicapi/commit/9d65260136faa1ff869ac49dff9086b7e2aa1939) Merge remote-tracking branch 'origin/main' into comarquet-main - [`aa3a41f`](https://github.com/sigma67/ytmusicapi/commit/aa3a41f1d6e72458da73914b05bd285f14206438) some improvements: remove_search_suggestions - [`4801d3a`](https://github.com/sigma67/ytmusicapi/commit/4801d3a1fa6a63d28b397325160758228b19d44e) make indices optional ### 📊 Changes **4 files changed** (+110 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `docs/source/reference.rst` (+2 -0) 📝 `tests/mixins/test_search.py` (+29 -0) 📝 `ytmusicapi/mixins/search.py` (+60 -7) 📝 `ytmusicapi/parsers/search.py` (+19 -5) </details> ### 📄 Description Related to #497 I modified parse_search_suggestions so that it retrieves the feedbackToken of each suggestion in the search bar and associates it with the number it is displayed when invoking get_search_suggestions, so that the function remove_search_suggestion can be called with the number as parameter to delete the corresponding entry. ![image](https://github.com/user-attachments/assets/8eb6a7cd-00cb-428f-b579-037a940b5f7a) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 23:02:03 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ytmusicapi#699
No description provided.