[PR #48] [CLOSED] Small fixes and improvements towards version 1.0 #86

New issue

Closed

opened 2026-03-03 18:48:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 18:48:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/oerg866/win98-quickinstall/pull/48
Author: @perchrh
Created: 7/6/2025
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (10+)

9329a84 Don't require a github+sshkey setup
3f371c0 Don't download terminfo etc on every build
f2b9470 Don't use the system's zlib if present
2f40223 Skip pylibmount build to avoid compilation issues
6322167 Make it clearer where sudo is required, and give a helpful hint for how to allow mknod to be called in an unpriviliged lxc container build environment
27c16d4 Make sysprep.py ready to run
20ef99d Avoid question about missing config option
2c4a646 Make comments easier to read, add two helpful prints about what's going on
6525307 Minor clarifications and fixes to make it easier to read. Importantly, remove outdated info that osroot uses a default value
c0bb703 Improve requirements description

📊 Changes

10 files changed (+110 additions, -63 deletions)

View changed files

📝 .gitmodules (+5 -5)
📝 BUILDING.md (+9 -6)
📝 README.md (+20 -17)
📝 build.sh (+21 -7)
📝 buildscripts/linux_config (+2 -0)
📝 buildscripts/linux_config.cd (+2 -0)
📝 buildscripts/linux_config.flp (+2 -0)
➕ buildscripts/pciutils_patches/disable_zlib.patch (+14 -0)
📝 init.sh (+21 -15)
📝 sysprep/sysprep.py (+14 -13)

📄 Description

Some build fixes I needed to build on a fresh install of Ubuntu 22.04 LTS. Some documentation improvements. Some quality of life improvements.
Tested ok with cdrom install and cd boot and floppy boot.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/oerg866/win98-quickinstall/pull/48 **Author:** [@perchrh](https://github.com/perchrh) **Created:** 7/6/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`9329a84`](https://github.com/oerg866/win98-quickinstall/commit/9329a84cf4585c51ba46990919df88cb7a54ed97) Don't require a github+sshkey setup - [`3f371c0`](https://github.com/oerg866/win98-quickinstall/commit/3f371c0751cfe8c8fd1df9a98a5176bfe4590128) Don't download terminfo etc on every build - [`f2b9470`](https://github.com/oerg866/win98-quickinstall/commit/f2b9470704146db1b5d9270e0ef611e03d7d5319) Don't use the system's zlib if present - [`2f40223`](https://github.com/oerg866/win98-quickinstall/commit/2f40223e7609719b939e2650ec7f9996b0e7077b) Skip pylibmount build to avoid compilation issues - [`6322167`](https://github.com/oerg866/win98-quickinstall/commit/6322167b69a5ac278387e61c29ea848259588c4e) Make it clearer where sudo is required, and give a helpful hint for how to allow mknod to be called in an unpriviliged lxc container build environment - [`27c16d4`](https://github.com/oerg866/win98-quickinstall/commit/27c16d4f717b15fdfa63a462d34cb6b48a65ca2a) Make sysprep.py ready to run - [`20ef99d`](https://github.com/oerg866/win98-quickinstall/commit/20ef99db49ad0dc14d3558ac2b8c0708a783a963) Avoid question about missing config option - [`2c4a646`](https://github.com/oerg866/win98-quickinstall/commit/2c4a64641991f3159f8e9b931935bd019bcdf986) Make comments easier to read, add two helpful prints about what's going on - [`6525307`](https://github.com/oerg866/win98-quickinstall/commit/652530746c8901981b23f56a9e5ba6fdc640dd76) Minor clarifications and fixes to make it easier to read. Importantly, remove outdated info that osroot uses a default value - [`c0bb703`](https://github.com/oerg866/win98-quickinstall/commit/c0bb70363ecf7e7fa64ce9ee004fd6c3e1f06275) Improve requirements description ### 📊 Changes **10 files changed** (+110 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `.gitmodules` (+5 -5) 📝 `BUILDING.md` (+9 -6) 📝 `README.md` (+20 -17) 📝 `build.sh` (+21 -7) 📝 `buildscripts/linux_config` (+2 -0) 📝 `buildscripts/linux_config.cd` (+2 -0) 📝 `buildscripts/linux_config.flp` (+2 -0) ➕ `buildscripts/pciutils_patches/disable_zlib.patch` (+14 -0) 📝 `init.sh` (+21 -15) 📝 `sysprep/sysprep.py` (+14 -13) </details> ### 📄 Description Some build fixes I needed to build on a fresh install of Ubuntu 22.04 LTS. Some documentation improvements. Some quality of life improvements. Tested ok with cdrom install and cd boot and floppy boot. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>