mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 04:05:57 +03:00
[GH-ISSUE #126] [BUG] Whoogle won't search right from the address bar #91
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#91
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cammelspit on GitHub (Sep 25, 2020).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/126
Describe the bug
When I have my Whoogle site set to be the default search engine, I type in a search term and instead of searching for that term, it just opens my Whoogle but the search term simply is not passed along.
To Reproduce
Steps to reproduce the behavior:
'
'
Deployment Method
runexecutableVersion of Whoogle Search
Desktop (please complete the following information):
Additional context
I have just today done a full reset of my OS, and this install of Firefox is as of now only a few hours old. I know it worked before but I don't know if it stopped recently (in the last couple of days) and I didn't notice or if it is exclusively an issue with my new OS install as I have been very busy with work and haven't really had the chance to notice.
@cammelspit commented on GitHub (Sep 25, 2020):
I don't know if this is what I did before to get it working because it's been long enough since I set up Whoogle that I genuinely can't recall. I was able to work around the issue by using THIS PLUGIN and just manually entering the string like you would for the mobile browser since the desktop Firefox can't do this normally for some silly reason.
So, I am happy again! LOVE Whoogle and I use it everywhere, I even use my Whoogle at work because it's all nice and exposed with a reserve proxy and SSL. Super slick, love it, keep doing excellent work!
@benbusby commented on GitHub (Sep 30, 2020):
That's interesting, I actually just randomly had this happen to me yesterday. For me it only happened once though, and all subsequent searches were forwarded to the correct endpoint. I'll try and do some testing with a debug build and see if I can reproduce it, but my initial impression is that it might be an issue either with the
opensearch.xmltemplate or with Firefox itself. It's bizarre either way though.@sutidor commented on GitHub (Nov 26, 2020):
Same issue here when I use nginx reverse proxy.
When I use plain whoogle http on port 5000 it does work. And if I use postman and POST q=123 on the URL I find in opensearch.xml it does work, too!
Any idea how to fix? Thx in advance
Update: I tried to set the option for "use GET only" on the main page, and it changes the opensearch.xml apparently, but the issue persists.
@sutidor commented on GitHub (Nov 30, 2020):
Solution
(I modified openxml according to ecosia's)
In the docker image the path is app/templates/opensearch.xml
For those who are interested, the difference is the kind of request. It formerly used params like so
<Param name="q" value="{searchTerms}"/>+ POST by default. Now I default to GET and moved everything directly to the querystring?q={searchTerms}.@benbusby commented on GitHub (Nov 30, 2020):
Interesting. The amount of issues that the opensearch format causes has been pretty annoying. I've found in the past that if parameters weren't given their own element (i.e.
<Param name=...), then browsers like Chrome would reject the template altogether. Likewise if themethodtag is declared at all (regardless of value) then Chrome will reject the template again. The solution that is currently in place on the develop branch/beta tag is to remove the method declaration if the user is using Chrome, and I haven't had any issues with the current implementation on any browser that I've tested.@benbusby commented on GitHub (Jan 14, 2021):
I think I'm going to close this one for now, as it doesn't seem to be easily replicated on Firefox or Chrome on my end. As of
github.com/benbusby/whoogle-search@a519de90afthis should've been completely fixed for Chrome, but if not, I'll open a new issue and investigate the opensearch formatting a bit further.