mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 04:05:57 +03:00
[GH-ISSUE #178] [BUG] opensearch.xml file served from HTTPS deployment mandates HTTP links instead of HTTPS #126
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#126
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @github-ronk on GitHub (Jan 21, 2021).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/178
Describe the bug
The opensearch.xml file served from HTTPS deployment mandates HTTP links instead of HTTPS.
One effect of this, is that when deploying on Heroku, adding it as a Firefox search engine and searching from the URL bar, the search query will be sent in plain text, not encrypted.
To Reproduce
Steps to reproduce the behavior:
Additionally:
4. Perform a search on this instance from Firefox URL bar
5. Observe the query in the Web Console - it is an HTTP query.
6. Same for the suggestions queries that are emitted when typing.
Deployment Method
runexecutableVersion of Whoogle Search
Comment
A temporary workaround is to enable the global "HTTPS only" setting in Firefox. But this impacts all sites, not just Whoogle.
@github-ronk commented on GitHub (Jan 21, 2021):
Actually it seems the heroku-app branch has not been updated for 0.3.0, After delete and re-deploy on Heroku we still have 0.2.1 there...
@benbusby commented on GitHub (Jan 21, 2021):
Thanks for pointing that out. I just updated the
heroku-appbranch, try with the latest version and let me know if you're still seeing that issue.@github-ronk commented on GitHub (Jan 23, 2021):
The update works fine, now 0.3.0 is deployed.
The issue still exists.
Thanks for looking into it.
@benbusby commented on GitHub (Jan 23, 2021):
I just pushed an update which I confirmed fixes this. Please try pulling the latest changes and trying again, and let me know if that fixes it for you.
Keep in mind that Firefox (and probably other browsers) tend to cache the opensearch xml file, so if it doesn't work right away, try clearing cached data for the site and reattempting to add it.
@github-ronk commented on GitHub (Jan 24, 2021):
Yes, getting HTTPS now on Heroku after re-deployment. Many thanks. Closing this.
@github-ronk commented on GitHub (Jan 24, 2021):
Confirmed Fixed in latest 0.3.0 on Heroku.