mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 20:25:51 +03:00
[GH-ISSUE #634] [BUG] WHOOGLE_MINIMAL removes search results #401
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#401
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DUOLabs333 on GitHub (Feb 1, 2022).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/634
Describe the bug
After some time, in some cases, a Whoogle search leads to an empty search page.
To Reproduce
Steps to reproduce the behavior:
Deployment Method
runexecutableVersion of Whoogle Search
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Add any other context about the problem here.
@bruvv commented on GitHub (Feb 1, 2022):
Log files are essential to debug this....
@DUOLabs333 commented on GitHub (Feb 1, 2022):
Whoogle doesn't output anything.
@ghost commented on GitHub (Feb 1, 2022):
I've seen this too, on 0.7.1 and also on 0.7.0 (Arch Linux, same whoogle setup). Removing
WHOOGLE_MINIMAL=1from whoogle.env (or settingWHOOGLE_MINIMAL=0) fixes this for me. Perhaps google changed something in those 'People also ask' cards that needs adjusting?@benbusby commented on GitHub (Feb 1, 2022):
Yep, looks like
WHOOGLE_MINIMALno longer works due to some behind the scenes changes to search result formatting.Edit: I'd be cautious about any fix at this point actually. It seems like they're doing A/B testing with how they format search results, so a fix for one response body might not work for the other and vice versa. I'm getting 50/50 odds of receiving a weird left-aligned search result response w/o div backgrounds vs the usual center-aligned results.
@DUOLabs333 commented on GitHub (Feb 1, 2022):
Oh, foo -- I really liked
WHOOGLE_MINIMALtoo.@DUOLabs333 commented on GitHub (Feb 1, 2022):
Also, side note --
body {max-width: 100% !important; /* or whatever width you want */}doesn't work anymore -- it's right aligned now.@benbusby commented on GitHub (Feb 2, 2022):
Yeah, likely related to the new result formatting that they're applying. I've noticed some styles are being forced as
!important, which overrides styles that Whoogle applies (even with!important). I'm going to keep an eye on what gets changed in the next few days. Over the course of the day I've noticed that my prior 50/50 odds of getting their new result format have gone up to almost 100% new formatted results, so this might be a permanent change. I just pushed9ba73331aa, which should eliminate some of the weird white box-shadow elements I was seeing, which looked really bad for dark themes in particular.@DUOLabs333 commented on GitHub (Feb 2, 2022):
I'm trying out a way to fix
MINIMAL-- incollapse_sections, is there a way to remove a section? Just settingresult_children=[]just causes a blank page.@benbusby commented on GitHub (Feb 2, 2022):
If the section is a BS4 element, then you can call
decompose()on that element (i.e.elem.decompose()).@DUOLabs333 commented on GitHub (Feb 2, 2022):
I got something that basically works -- it should work with both types of response bodies.
@DUOLabs333 commented on GitHub (Feb 2, 2022):
When you remove a section, a line is left behind -- it there a way to remove that?
@benbusby commented on GitHub (Feb 2, 2022):
Hmm, I'm not sure really. I'm assuming it's leftover css, like a border being applied to an empty div (or something along those lines). Maybe for whatever section you're removing, it would be more accurate to remove its immediate parent element instead?
@DUOLabs333 commented on GitHub (Feb 2, 2022):
I removed the "Top stories" section, how would I remove the parent element?
@benbusby commented on GitHub (Feb 2, 2022):
By calling
<elem>.parent.decompose()instead of justdecompose(), although I can't promise that's the solution, just a hunch.@DUOLabs333 commented on GitHub (Feb 2, 2022):
Oh, I got it to work: I just called
result.decompose()@DUOLabs333 commented on GitHub (Feb 2, 2022):
I'll make a pull request soon.
@ghost commented on GitHub (Feb 2, 2022):
Confirming #637 fixes
WHOOGLE_MINIMAL=1here.@servietos commented on GitHub (Jan 16, 2025):
Hello thank you for that great application. However I'm on v0.9.1 and got an empty search result but only at 'All'. Images, Maps, Video and News deliver results. I'm using Whoogle as a docker container and re-installed it freshly with the same behavior.
May you've any idea, please?
@bruvv commented on GitHub (Jan 16, 2025):
@servietos https://github.com/benbusby/whoogle-search/issues/1211 please do not comment on closed issues if there are open issues.