mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #31] Configurable config.json location #22
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#22
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @FoxxMD on GitHub (May 12, 2020).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/31
Describe the feature you'd like to see added
static/config.jsonis used to set the main configuration settings for whoogle. However when the docker container is rebuilt these settings are lost.Please modify the location of
config.jsonso that it is easier for docker users to provide a volume-mounted copy to the container so we can persist our settings between rebuilds.Describe which parts of the project this would modify (front end/back end/configuration/etc)
Minimal changes to achieve this
Move
config.jsoninto its own folder outside of static, preferably to a location that does not need other files to be written to it. Additionally make sure whoogle does not overwrite this directory/file if it already exists at setup.With a hardcoded, but separate, directory a docker user can easily volume-mount a folder to that location and provide their own
config.json.Optionally
Expose the configuration directory string as an environmental variable in the Dockerfile so users can set their own directory.
@benbusby commented on GitHub (May 13, 2020):
Mind trying out the feature/config-volume branch in #39 and see if I'm missing anything missing? I believe that update will satisfy this request. Seemed to be working pretty well for me, if it looks good to you then I'll merge.
@FoxxMD commented on GitHub (May 13, 2020):
Looks good to me too! Could you possibly publish the branch as a tag on dockerhub? That's how I'm running it (in unraid) right now and would make it like 10 seconds to test it for me 😅
@benbusby commented on GitHub (May 13, 2020):
Available under the
config-volumetag on dockerhub now. Let me know if it works for you!@s3rverro0m commented on GitHub (May 13, 2020):
I just pulled this container and the config saves to the directory that I specified.
Only issue I see with this is if you save the config outside, and your friend uses it...they get your settings. Haha.
@FoxxMD commented on GitHub (May 13, 2020):
@benbusby it works! thank you!!
@r0arkin that would be the case regardless of this change though.
@s3rverro0m commented on GitHub (May 13, 2020):
That is very true! I just thought about it.
@ghost commented on GitHub (May 14, 2020):
Any plans to push this to
:lateston Docker Hub or will this be the branch to permanently follow for this change?@FoxxMD commented on GitHub (May 14, 2020):
p.s. ben you can setup automated builds based on branch in dockerhub
