mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #298] [FEATURE] Include category tabs (all/images/news/etc) in header #207
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#207
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @unixfox on GitHub (Apr 25, 2021).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/298
Describe the bug
The image tab has a different layout (CSS?) from the other tabs like "all", "videos", "news". The text of the menu is bigger on the image tab.
Moreover, in the image tab I'm not able to access maps nor books, those links aren't displayed.
Is this intended? It's a bit disturbing to have a sudden change of layout like this.
To Reproduce
Steps to reproduce the behavior:
Deployment Method
runexecutableVersion of Whoogle Search
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
@benbusby commented on GitHub (May 5, 2021):
It's not necessarily "intended", but is an inadvertent side effect of using Google's non-Javascript search query. For some reason the default styling on the image page is just different. Very little styling (outside of color theming) is performed by Whoogle.
I agree that it's a bit jarring, though. I think the best solution at the moment would be to include the category tabs in
header.htmland remove them when parsing the results in the Whoogle filter. There would need to be some coordination with #256 though, since otherwise the category tab titles would not reflect the user's preferred language on search results.@benbusby commented on GitHub (Nov 7, 2021):
Note that this should also include language selection and time filtering, as noted in #524.