mirror of
https://github.com/benbusby/whoogle-search.git
synced 2026-04-25 12:15:50 +03:00
[GH-ISSUE #2] Add config option to enable ads #2
Labels
No labels
Fixed (Pending PR Merge)
Stale
bug
enhancement
enhancement
good first issue
help wanted
keep-open
needs more info
pull-request
question
theme
unfortunate
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/whoogle-search#2
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @benbusby on GitHub (May 10, 2020).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/2
ProbablyDefinitely leave as false, but should offer the option to still see ads if desired.@RainmakerRaw commented on GitHub (May 10, 2020):
'Probably'? Please don't implement this.
@benbusby commented on GitHub (May 10, 2020):
Yeah that was just me thinking aloud, should've said "definitely". This came up in this discussion: https://www.reddit.com/r/selfhosted/comments/ggronz/whoogle_search_a_selfhosted/fq47w9e/?context=3
If it's an optional feature I personally don't see the problem, even though I'd never use the feature myself.
@benbusby commented on GitHub (May 13, 2020):
Going to close this one for now, I've gotten a fair amount of private and public pushback for this -- though again, I don't see the problem personally if it's hidden behind a config setting. Other features/bugs are higher priority at the moment, but I'd welcome a pull request implementing this in a reasonable manner.