[GH-ISSUE #2] Add config option to enable ads #2

Closed
opened 2026-02-25 20:34:38 +03:00 by kerem · 3 comments
Owner

Originally created by @benbusby on GitHub (May 10, 2020).
Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/2

Probably Definitely leave as false, but should offer the option to still see ads if desired.

Originally created by @benbusby on GitHub (May 10, 2020). Original GitHub issue: https://github.com/benbusby/whoogle-search/issues/2 ~~Probably~~ Definitely leave as false, but should offer the option to still see ads if desired.
kerem 2026-02-25 20:34:38 +03:00
Author
Owner

@RainmakerRaw commented on GitHub (May 10, 2020):

'Probably'? Please don't implement this.

<!-- gh-comment-id:626269254 --> @RainmakerRaw commented on GitHub (May 10, 2020): 'Probably'? _Please_ don't implement this.
Author
Owner

@benbusby commented on GitHub (May 10, 2020):

Yeah that was just me thinking aloud, should've said "definitely". This came up in this discussion: https://www.reddit.com/r/selfhosted/comments/ggronz/whoogle_search_a_selfhosted/fq47w9e/?context=3

If it's an optional feature I personally don't see the problem, even though I'd never use the feature myself.

<!-- gh-comment-id:626273011 --> @benbusby commented on GitHub (May 10, 2020): Yeah that was just me thinking aloud, should've said "definitely". This came up in this discussion: https://www.reddit.com/r/selfhosted/comments/ggronz/whoogle_search_a_selfhosted/fq47w9e/?context=3 If it's an optional feature I personally don't see the problem, even though I'd never use the feature myself.
Author
Owner

@benbusby commented on GitHub (May 13, 2020):

Going to close this one for now, I've gotten a fair amount of private and public pushback for this -- though again, I don't see the problem personally if it's hidden behind a config setting. Other features/bugs are higher priority at the moment, but I'd welcome a pull request implementing this in a reasonable manner.

<!-- gh-comment-id:628188016 --> @benbusby commented on GitHub (May 13, 2020): Going to close this one for now, I've gotten a fair amount of private and public pushback for this -- though again, I don't see the problem personally if it's hidden behind a config setting. Other features/bugs are higher priority at the moment, but I'd welcome a pull request implementing this in a reasonable manner.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/whoogle-search#2
No description provided.