[PR #202] [MERGED] for rbd devices, evaluate name field for graceful error message #593

New issue

Closed

opened 2026-02-27 16:39:49 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 16:39:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtmgr/pull/202
Author: @EmbeddedAndroid
Created: 1/26/2014
Status: ✅ Merged
Merged: 1/26/2014
Merged by: @retspen

Base: master ← Head: master

📝 Commits (1)

01410e3 for rbd devices, evaluate name field for graceful error message

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 vrtManager/instance.py (+1 -1)

📄 Description

When using rbd devices such as:

<disk type='network' device='disk'>
  <driver name='qemu' type='raw'/>
  <auth username='libvirt'>
    <secret type='ceph' uuid='dc28392e-a277-4077-80ed-07040f5daffb'/>
  </auth>
  <source protocol='rbd' name='data/controller'>
    <host name='compute01' port='6789'/>
    <host name='192.168.1.2' port='6789'/>
  </source>
  <target dev='vdz' bus='virtio'/>
  <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/>
</disk>

Viewing the instance configuration causes a 500, as disk.xpathEval('source/@file|source/@dev')[0] throws an index error as one might expect. If we use the name field to lookup the storage volume, the instance view is displayed, however a graceful error is displayed:

https://drive.google.com/file/d/0B9DbsE2BbZ7uQzlrSEZBbG1UUnM/edit?usp=sharing

Signed-off-by: Tyler Baker tyler.baker@linaro.org

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtmgr/pull/202 **Author:** [@EmbeddedAndroid](https://github.com/EmbeddedAndroid) **Created:** 1/26/2014 **Status:** ✅ Merged **Merged:** 1/26/2014 **Merged by:** [@retspen](https://github.com/retspen) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`01410e3`](https://github.com/retspen/webvirtmgr/commit/01410e30404edd4bea149e95044a041d5fba2ad1) for rbd devices, evaluate name field for graceful error message ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `vrtManager/instance.py` (+1 -1) </details> ### 📄 Description When using rbd devices such as: ``` <disk type='network' device='disk'> <driver name='qemu' type='raw'/> <auth username='libvirt'> <secret type='ceph' uuid='dc28392e-a277-4077-80ed-07040f5daffb'/> </auth> <source protocol='rbd' name='data/controller'> <host name='compute01' port='6789'/> <host name='192.168.1.2' port='6789'/> </source> <target dev='vdz' bus='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/> </disk> ``` Viewing the instance configuration causes a 500, as disk.xpathEval('source/@file|source/@dev')[0] throws an index error as one might expect. If we use the name field to lookup the storage volume, the instance view is displayed, however a graceful error is displayed: https://drive.google.com/file/d/0B9DbsE2BbZ7uQzlrSEZBbG1UUnM/edit?usp=sharing Signed-off-by: Tyler Baker tyler.baker@linaro.org --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>