starred/webvirtcloud
1
0
Fork 0
mirror of https://github.com/retspen/webvirtcloud.git synced 2026-04-25 15:35:57 +03:00
Code Issues 199 Projects Releases 1 Packages Wiki Activity

[GH-ISSUE #440] Hardcoded websocket path when using noVNC full version #269

New issue
Closed
opened 2026-02-27 15:58:03 +03:00 by kerem · 10 comments
kerem commented 2026-02-27 15:58:03 +03:00
Owner
Copy link

Originally created by @wongsyrone on GitHub (May 26, 2021).
Original GitHub issue: https://github.com/retspen/webvirtcloud/issues/440

I have to change ws_path everytime when I want to use noVNC full variant.

Hardcoded here:
github.com/retspen/webvirtcloud@a20fa8e8d7/console/templates/console-vnc-full.html (L221-L222)

The lite version works because:
github.com/retspen/webvirtcloud@a20fa8e8d7/console/templates/console-vnc-lite.html (L177-L178)

get data from:

github.com/retspen/webvirtcloud@a20fa8e8d7/console/views.py (L74-L87)

Originally created by @wongsyrone on GitHub (May 26, 2021). Original GitHub issue: https://github.com/retspen/webvirtcloud/issues/440 I have to change ws_path everytime when I want to use noVNC full variant. Hardcoded here: https://github.com/retspen/webvirtcloud/blob/a20fa8e8d76a442ea4225c469d7666aab5b15e8d/console/templates/console-vnc-full.html#L221-L222 The lite version works because: https://github.com/retspen/webvirtcloud/blob/a20fa8e8d76a442ea4225c469d7666aab5b15e8d/console/templates/console-vnc-lite.html#L177-L178 get data from: https://github.com/retspen/webvirtcloud/blob/a20fa8e8d76a442ea4225c469d7666aab5b15e8d/console/views.py#L74-L87
kerem closed this issue 2026-02-27 15:58:03 +03:00
kerem commented 2026-02-27 15:58:03 +03:00
Author
Owner
Copy link

@wongsyrone commented on GitHub (May 26, 2021):

The issue is caused by github.com/retspen/webvirtcloud@43f1461e29

<!-- gh-comment-id:848587186 --> @wongsyrone commented on GitHub (May 26, 2021): The issue is caused by https://github.com/retspen/webvirtcloud/commit/43f1461e299fecb72fe05958d37c33702c3dbe94
kerem commented 2026-02-27 15:58:03 +03:00
Author
Owner
Copy link

@wongsyrone commented on GitHub (May 26, 2021):

@catborise @retspen The template got removed from the commit above. Is it intentional?

<!-- gh-comment-id:848591053 --> @wongsyrone commented on GitHub (May 26, 2021): @catborise @retspen The template got removed from the commit above. Is it intentional?
kerem commented 2026-02-27 15:58:03 +03:00
Author
Owner
Copy link

@catborise commented on GitHub (May 26, 2021):

I dont think it is intentional change, may be it is missed. We could change it, if it is useful.

<!-- gh-comment-id:848620277 --> @catborise commented on GitHub (May 26, 2021): I dont think it is intentional change, may be it is missed. We could change it, if it is useful.
kerem commented 2026-02-27 15:58:03 +03:00
Author
Owner
Copy link

@wongsyrone commented on GitHub (May 26, 2021):

I think it's useful as it's more convenient.

<!-- gh-comment-id:848697559 --> @wongsyrone commented on GitHub (May 26, 2021): I think it's useful as it's more convenient.
kerem commented 2026-02-27 15:58:03 +03:00
Author
Owner
Copy link

@wongsyrone commented on GitHub (May 29, 2021):

@catborise Any update on this?

<!-- gh-comment-id:850769331 --> @wongsyrone commented on GitHub (May 29, 2021): @catborise Any update on this?
kerem commented 2026-02-27 15:58:03 +03:00
Author
Owner
Copy link

@catborise commented on GitHub (May 31, 2021):

@wongsyrone it is initiated at different place. changing "websockify" does not affect. i think it is set in UI.js which is not reach ws_path value.

<!-- gh-comment-id:851284846 --> @catborise commented on GitHub (May 31, 2021): @wongsyrone it is initiated at different place. changing "websockify" does not affect. i think it is set in UI.js which is not reach ws_path value.
kerem commented 2026-02-27 15:58:03 +03:00
Author
Owner
Copy link

@wongsyrone commented on GitHub (May 31, 2021):

@catborise

Nope. I fixed it on my side by reverting partial changes (console-vnc-full.html) of github.com/retspen/webvirtcloud@43f1461e29

<!-- gh-comment-id:851700500 --> @wongsyrone commented on GitHub (May 31, 2021): @catborise Nope. I fixed it on my side by reverting partial changes (console-vnc-full.html) of https://github.com/retspen/webvirtcloud/commit/43f1461e299fecb72fe05958d37c33702c3dbe94
kerem commented 2026-02-27 15:58:03 +03:00
Author
Owner
Copy link

@catborise commented on GitHub (Jun 2, 2021):

@wongsyrone i change it. but i cannot test it(my test shows no effect). if it is working fine...

<!-- gh-comment-id:852938852 --> @catborise commented on GitHub (Jun 2, 2021): @wongsyrone i change it. but i cannot test it(my test shows no effect). if it is working fine...
kerem commented 2026-02-27 15:58:03 +03:00
Author
Owner
Copy link

@wongsyrone commented on GitHub (Jun 2, 2021):

github.com/retspen/webvirtcloud@24cd3f70dd looks good to me.

<!-- gh-comment-id:853425893 --> @wongsyrone commented on GitHub (Jun 2, 2021): https://github.com/retspen/webvirtcloud/commit/24cd3f70ddefe529b97e019fa46c54180c64b725 looks good to me.
kerem commented 2026-02-27 15:58:03 +03:00
Author
Owner
Copy link

@MisterBlueBear commented on GitHub (Aug 24, 2023):

I don't think this fix works at all. If I view the HTML source, I do see the correct HTML code, but in the console settings, it is still set to "websockify".

May I suggest just adding the location conf for "websockify" to /etc/nginx/conf.d/webvirtcloud.conf as a workaround. This fixes the issue.

    location /websockify {
        proxy_pass http://wssocketiod;
        proxy_http_version 1.1;
        proxy_set_header Upgrade $http_upgrade;
        proxy_set_header Connection "upgrade";
    }
<!-- gh-comment-id:1691027113 --> @MisterBlueBear commented on GitHub (Aug 24, 2023): I don't think this fix works at all. If I view the HTML source, I do see the correct HTML code, but in the console settings, it is still set to "websockify". May I suggest just adding the location conf for "**websockify**" to /etc/nginx/conf.d/webvirtcloud.conf as a workaround. This fixes the issue. ``` location /websockify { proxy_pass http://wssocketiod; proxy_http_version 1.1; proxy_set_header Upgrade $http_upgrade; proxy_set_header Connection "upgrade"; } ```
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
v1.0
Labels
Clear labels   
bug

   
enhancement

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
enhancement
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/webvirtcloud#269
No description provided.