[PR #159] [CLOSED] Fixed login page not working and instances page not working (loading) too. #440

New issue

Closed

opened 2026-02-27 15:58:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:58:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/retspen/webvirtcloud/pull/159
Author: @lord-kyron
Created: 7/6/2018
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (2)

cfa9fd6 initial comit
1204c6d return original README file

📊 Changes

2 files changed (+7 additions, -4 deletions)

View changed files

📝 accounts/urls.py (+6 -3)
📝 instances/views.py (+1 -1)

📄 Description

@retspen - as already described - you've merged @catborise changes, but his code has 2 problems:

login page is not loading - I've took your original accounts/urls.py file and use id instead of @catborise modified one. It is working with it, but it will be best if you or @catborise review and fix the modified version.
instances page was not loading too, because of miss-configured variable, used on line 88 of instances/views.py file. I've fixed it and it is working now as expected.

Please, do the merge in order the code in your repo to be fully functional and working without any problems at this point!
Thanks!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/retspen/webvirtcloud/pull/159 **Author:** [@lord-kyron](https://github.com/lord-kyron) **Created:** 7/6/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`cfa9fd6`](https://github.com/retspen/webvirtcloud/commit/cfa9fd6066e17479bfda0fc93b8aff88d2028ea4) initial comit - [`1204c6d`](https://github.com/retspen/webvirtcloud/commit/1204c6d1b4096d3dfc756fbd3419fa774ecf83eb) return original README file ### 📊 Changes **2 files changed** (+7 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `accounts/urls.py` (+6 -3) 📝 `instances/views.py` (+1 -1) </details> ### 📄 Description @retspen - as already described - you've merged @catborise changes, but his code has 2 problems: - login page is not loading - I've took your original accounts/urls.py file and use id instead of @catborise modified one. It is working with it, but it will be best if you or @catborise review and fix the modified version. - instances page was not loading too, because of miss-configured variable, used on line 88 of instances/views.py file. I've fixed it and it is working now as expected. Please, do the merge in order the code in your repo to be fully functional and working without any problems at this point! Thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>