[PR #3757] [MERGED] Fix #3413: push to users accessing the collections using groups #3337

New issue

Closed

opened 2026-03-03 09:58:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:58:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3757
Author: @matlink
Created: 8/5/2023
Status: ✅ Merged
Merged: 1/1/2024
Merged by: @dani-garcia

Base: main ← Head: 3413_live_sync_groups

📝 Commits (2)

96f9d18 Fix #3413: push to users acessing the collections using groups
c09db88 Notify groups only when enabled

📊 Changes

2 files changed (+36 additions, -1 deletions)

View changed files

📝 src/db/models/cipher.rs (+10 -1)
📝 src/db/models/organization.rs (+26 -0)

📄 Description

I bet it can be done with a single query within the find_by_cipher_and_org function but I didn't managed to get it work (the filter gets complicated, adding groups::access_all.eq(true) works but I can't figure out how to check if the user is in a group that has access to the collection).

Basically it retrieves the users having access to the cipher with a group that either has access to all collections or is bound to the cipher's collection. Then users uuid are used to push changes to clients.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3757 **Author:** [@matlink](https://github.com/matlink) **Created:** 8/5/2023 **Status:** ✅ Merged **Merged:** 1/1/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `3413_live_sync_groups` --- ### 📝 Commits (2) - [`96f9d18`](https://github.com/dani-garcia/vaultwarden/commit/96f9d1858cdc0c8a172b470199aa23cc006472fe) Fix #3413: push to users acessing the collections using groups - [`c09db88`](https://github.com/dani-garcia/vaultwarden/commit/c09db88f4e4dc31d7294470464deda72cb976ead) Notify groups only when enabled ### 📊 Changes **2 files changed** (+36 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/db/models/cipher.rs` (+10 -1) 📝 `src/db/models/organization.rs` (+26 -0) </details> ### 📄 Description I bet it can be done with a single query within the `find_by_cipher_and_org` function but I didn't managed to get it work (the `filter` gets complicated, adding `groups::access_all.eq(true)` works but I can't figure out how to check if the user is in a group that has access to the collection). Basically it retrieves the users having access to the cipher with a group that either has access to all collections or is bound to the cipher's collection. Then users uuid are used to push changes to clients. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>