[PR #4315] [MERGED] Fix env templateto ensure compatibility with systemd's EnvironmentFile parsing #3413

New issue

Closed

opened 2026-03-03 09:58:47 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:58:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4315
Author: @seiuneko
Created: 2/3/2024
Status: ✅ Merged
Merged: 2/19/2024
Merged by: @dani-garcia

Base: main ← Head: systemd-envfile-comment-fix

📝 Commits (2)

7076422 fix: update env template for systemd compatibility
2aec172 Refactor SMTP and Rocket settings in .env.template

📊 Changes

1 file changed (+11 additions, -3 deletions)

View changed files

📝 .env.template (+11 -3)

📄 Description

This commit addresses an issue in the Vaultwarden project's .env.template file where comments explaining environment variable options were incorrectly placed on the same line as the variable definitions. Systemd's EnvironmentFile directive only recognizes comment symbols (#) at the beginning of a line. Therefore, explanatory comments placed on the same line as environment variable definitions can lead to misinterpretations or errors when the file is used in a systemd service file.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4315 **Author:** [@seiuneko](https://github.com/seiuneko) **Created:** 2/3/2024 **Status:** ✅ Merged **Merged:** 2/19/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `systemd-envfile-comment-fix` --- ### 📝 Commits (2) - [`7076422`](https://github.com/dani-garcia/vaultwarden/commit/7076422ee3a1e23b16e3fc2d880cee30b896848a) fix: update env template for systemd compatibility - [`2aec172`](https://github.com/dani-garcia/vaultwarden/commit/2aec1724dead3c1df2e4d28d308af604dc1ba6e4) Refactor SMTP and Rocket settings in .env.template ### 📊 Changes **1 file changed** (+11 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.env.template` (+11 -3) </details> ### 📄 Description This commit addresses an issue in the Vaultwarden project's `.env.template` file where comments explaining environment variable options were incorrectly placed on the same line as the variable definitions. Systemd's `EnvironmentFile` directive only recognizes comment symbols (#) at the beginning of a line. Therefore, explanatory comments placed on the same line as environment variable definitions can lead to misinterpretations or errors when the file is used in a systemd service file. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>