[PR #3124] [MERGED] Change text/plain API responses to application/json #3219

Closed
opened 2026-03-03 09:41:57 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3124
Author: @jjlin
Created: 1/7/2023
Status: Merged
Merged: 1/9/2023
Merged by: @dani-garcia

Base: mainHead: json-response


📝 Commits (1)

  • 4d9d649 Change text/plain API responses to application/json

📊 Changes

1 file changed (+6 additions, -9 deletions)

View changed files

📝 src/api/core/accounts.rs (+6 -9)

📄 Description

Recent versions of the Bitwarden clients (see bitwarden/clients#3574) won't parse non-JSON responses. The most noticeable consequence is that /api/accounts/revision-date responses won't be parsed, leading to /api/sync always being called, even when it's not necessary.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3124 **Author:** [@jjlin](https://github.com/jjlin) **Created:** 1/7/2023 **Status:** ✅ Merged **Merged:** 1/9/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `json-response` --- ### 📝 Commits (1) - [`4d9d649`](https://github.com/dani-garcia/vaultwarden/commit/4d9d649db98c4d80f121dce2c4661f548c39633a) Change `text/plain` API responses to `application/json` ### 📊 Changes **1 file changed** (+6 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/accounts.rs` (+6 -9) </details> ### 📄 Description Recent versions of the Bitwarden clients (see bitwarden/clients#3574) won't parse non-JSON responses. The most noticeable consequence is that `/api/accounts/revision-date` responses won't be parsed, leading to `/api/sync` always being called, even when it's not necessary. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 09:41:57 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vaultwarden#3219
No description provided.