[PR #2650] [MERGED] Mitigate attachment/send upload issues #3124

New issue

Closed

opened 2026-03-03 09:25:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:25:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/2650
Author: @BlackDex
Created: 7/27/2022
Status: ✅ Merged
Merged: 7/27/2022
Merged by: @dani-garcia

Base: main ← Head: mitigate-mobile-client-uploads

📝 Commits (1)

abfa868 Mitigate attachment/send upload issues

📊 Changes

2 files changed (+22 additions, -0 deletions)

View changed files

📝 src/api/core/ciphers.rs (+11 -0)
📝 src/api/core/sends.rs (+11 -0)

📄 Description

This PR attends to mitigate (not fix) #2644.
There seems to be an issue when uploading files either as attachment or
via send via the mobile (Android) client.

The binary data gets transfered correctly to Vaultwarden (Checked via
Wireshark), but the data is not parsed correctly for some reason.

Since the parsing is not done by Vaultwarden it self, i think we should
at least try to prevent saving the data and letting users think all
fine.

Further investigation is needed to actually fix this issue.
This is just a quick patch.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2650 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 7/27/2022 **Status:** ✅ Merged **Merged:** 7/27/2022 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `mitigate-mobile-client-uploads` --- ### 📝 Commits (1) - [`abfa868`](https://github.com/dani-garcia/vaultwarden/commit/abfa8684231c2426e5c8c0228b3f9fa41b62e713) Mitigate attachment/send upload issues ### 📊 Changes **2 files changed** (+22 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+11 -0) 📝 `src/api/core/sends.rs` (+11 -0) </details> ### 📄 Description This PR attends to mitigate (not fix) #2644. There seems to be an issue when uploading files either as attachment or via send via the mobile (Android) client. The binary data gets transfered correctly to Vaultwarden (Checked via Wireshark), but the data is not parsed correctly for some reason. Since the parsing is not done by Vaultwarden it self, i think we should at least try to prevent saving the data and letting users think all fine. Further investigation is needed to actually fix this issue. This is just a quick patch. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>