[PR #2729] [MERGED] Change the handling of login errors. #3137

New issue

Closed

opened 2026-03-03 09:26:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 09:26:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/2729
Author: @BlackDex
Created: 9/6/2022
Status: ✅ Merged
Merged: 9/8/2022
Merged by: @dani-garcia

Base: main ← Head: vw-admin-updates

📝 Commits (1)

5a05139 Change the handling of login errors.

📊 Changes

6 files changed (+262 additions, -1205 deletions)

View changed files

📝 src/api/admin.rs (+29 -17)
📝 src/api/web.rs (+2 -2)
📝 src/static/scripts/bootstrap.css (+120 -1103)
📝 src/static/scripts/jquery-3.6.1.slim.js (+109 -81)
📝 src/static/templates/admin/organizations.hbs (+1 -1)
📝 src/static/templates/admin/users.hbs (+1 -1)

📄 Description

Previously FlashMessage was used to provide an error message during login.
This PR changes that flow to not use redirect for this, but renders the HTML and responds using the correct status code where needed. This should solve some issues which were reported in the past.

Thanks to @RealOrangeOne, for initiating this with a PR.

Fixes #2448
Fixes #2712
Closes #2715

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2729 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 9/6/2022 **Status:** ✅ Merged **Merged:** 9/8/2022 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `vw-admin-updates` --- ### 📝 Commits (1) - [`5a05139`](https://github.com/dani-garcia/vaultwarden/commit/5a05139efe484b37edbc2db6eb618676d26f3723) Change the handling of login errors. ### 📊 Changes **6 files changed** (+262 additions, -1205 deletions) <details> <summary>View changed files</summary> 📝 `src/api/admin.rs` (+29 -17) 📝 `src/api/web.rs` (+2 -2) 📝 `src/static/scripts/bootstrap.css` (+120 -1103) 📝 `src/static/scripts/jquery-3.6.1.slim.js` (+109 -81) 📝 `src/static/templates/admin/organizations.hbs` (+1 -1) 📝 `src/static/templates/admin/users.hbs` (+1 -1) </details> ### 📄 Description Previously FlashMessage was used to provide an error message during login. This PR changes that flow to not use redirect for this, but renders the HTML and responds using the correct status code where needed. This should solve some issues which were reported in the past. Thanks to @RealOrangeOne, for initiating this with a PR. Fixes #2448 Fixes #2712 Closes #2715 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>