[PR #370] [MERGED] Added better favicon downloader. #2715

New issue

Closed

opened 2026-03-03 08:36:38 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 08:36:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/370
Author: @BlackDex
Created: 1/27/2019
Status: ✅ Merged
Merged: 1/27/2019
Merged by: @dani-garcia

Base: master ← Head: favicons

📝 Commits (3)

9657463 Added better favicon downloader.
da068a4 Moved function call to get_icon_url to prevent error bubbeling
4de16b2 Removed unwrap and added ?

📊 Changes

5 files changed (+304 additions, -10 deletions)

View changed files

📝 Cargo.lock (+124 -0)
📝 Cargo.toml (+5 -0)
📝 src/api/icons.rs (+172 -10)
📝 src/error.rs (+2 -0)
📝 src/main.rs (+1 -0)

📄 Description

Changed the favicon downloader to use the main html page with <link rel="*icon*"> selection.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/370 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 1/27/2019 **Status:** ✅ Merged **Merged:** 1/27/2019 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `favicons` --- ### 📝 Commits (3) - [`9657463`](https://github.com/dani-garcia/vaultwarden/commit/9657463717048519dd3683d2f2add52fa2c91205) Added better favicon downloader. - [`da068a4`](https://github.com/dani-garcia/vaultwarden/commit/da068a43c1fc4c349875d2cdab90a2c41af430c0) Moved function call to get_icon_url to prevent error bubbeling - [`4de16b2`](https://github.com/dani-garcia/vaultwarden/commit/4de16b2d17fd16666045a0d3d7e1ad99fc4df58c) Removed unwrap and added ? ### 📊 Changes **5 files changed** (+304 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+124 -0) 📝 `Cargo.toml` (+5 -0) 📝 `src/api/icons.rs` (+172 -10) 📝 `src/error.rs` (+2 -0) 📝 `src/main.rs` (+1 -0) </details> ### 📄 Description Changed the favicon downloader to use the main html page with `<link rel="*icon*">` selection. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>