[PR #710] [MERGED] Fixed issue #709 creating icon_cache directory. #2787

New issue

Closed

opened 2026-03-03 08:53:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 08:53:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/710
Author: @BlackDex
Created: 11/6/2019
Status: ✅ Merged
Merged: 11/6/2019
Merged by: @dani-garcia

Base: master ← Head: issue-709

📝 Commits (3)

ca7c512 Fixed issue #709 creating icon_cache directory.
0ff7fd9 Next attempt for issue #709 fix
2ffc3ea Clippy fix

📊 Changes

2 files changed (+23 additions, -13 deletions)

View changed files

📝 src/api/icons.rs (+14 -11)
📝 src/main.rs (+9 -2)

📄 Description

When the icon_cache directory doesn't exists yet, and the first icon
catched is a miss this .miss file was not able to be created since the
directory was only created during a valid icon download.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/710 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 11/6/2019 **Status:** ✅ Merged **Merged:** 11/6/2019 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `issue-709` --- ### 📝 Commits (3) - [`ca7c512`](https://github.com/dani-garcia/vaultwarden/commit/ca7c5129b2eadabed826cd82b6c291c0cb68cda9) Fixed issue #709 creating icon_cache directory. - [`0ff7fd9`](https://github.com/dani-garcia/vaultwarden/commit/0ff7fd939e9afe2197bb53eb37bce7d2b62f0b7f) Next attempt for issue #709 fix - [`2ffc3ea`](https://github.com/dani-garcia/vaultwarden/commit/2ffc3eac4da67c82db0d7dbc361295a047139499) Clippy fix ### 📊 Changes **2 files changed** (+23 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/api/icons.rs` (+14 -11) 📝 `src/main.rs` (+9 -2) </details> ### 📄 Description When the icon_cache directory doesn't exists yet, and the first icon catched is a miss this .miss file was not able to be created since the directory was only created during a valid icon download. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>