[PR #666] [MERGED] Fix 2FA email not sending #2774

New issue

Closed

opened 2026-03-03 08:53:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 08:53:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/666
Author: @vplme
Created: 10/15/2019
Status: ✅ Merged
Merged: 10/15/2019
Merged by: @dani-garcia

Base: master ← Head: fix-2fa-email

📝 Commits (2)

18bc833 Send email when preparing 2FA JsonError
2edecf3 Use user_uuid instead of mut twofactor

📊 Changes

2 files changed (+16 additions, -2 deletions)

View changed files

📝 src/api/core/two_factor/email.rs (+9 -1)
📝 src/api/identity.rs (+7 -1)

📄 Description

The 2FA email was not sent when email was the only 2FA method available.

Moved generate token, save token and send email logic to separate function.
Called from the separate send-email-login API call and when Email is the only 2FA provider in the invalid grant JsonError response.

Fixes #611

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/666 **Author:** [@vplme](https://github.com/vplme) **Created:** 10/15/2019 **Status:** ✅ Merged **Merged:** 10/15/2019 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `fix-2fa-email` --- ### 📝 Commits (2) - [`18bc833`](https://github.com/dani-garcia/vaultwarden/commit/18bc8331f9a27421b3913af4a8f070255cf3caba) Send email when preparing 2FA JsonError - [`2edecf3`](https://github.com/dani-garcia/vaultwarden/commit/2edecf34fff71ec1c89c05b5f6c5b6121eed715d) Use user_uuid instead of mut twofactor ### 📊 Changes **2 files changed** (+16 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/two_factor/email.rs` (+9 -1) 📝 `src/api/identity.rs` (+7 -1) </details> ### 📄 Description The 2FA email was not sent when email was the only 2FA method available. Moved generate token, save token and send email logic to separate function. Called from the separate `send-email-login` API call and when Email is the only 2FA provider in the `invalid grant` JsonError response. Fixes #611 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>