mirror of
https://github.com/nextcloud/twofactor_gateway.git
synced 2026-04-25 17:15:53 +03:00
[GH-ISSUE #173] Integrating eCall SMS Provider #45
Labels
No labels
0. to triage
1. to develop
3. to review
blocked
bug
discussion
duplicate
enhancement
enhancement
gateway:signal
gateway:signal
gateway:signal
gateway:sms
gateway:telegram
hacktoberfest
help wanted
invalid
needs info
php
pull-request
question
technical debt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/twofactor_gateway-nextcloud#45
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @FabianZihlmann on GitHub (Jan 4, 2019).
Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/173
@all
I would be very happy, someone could integrate a new SMS provider into the code. Was studying myself but did not get all the details that have to added for a new provider.
I'm using eCall Swiss SMS provider with following url:
https://www.ecall.ch/ecallurl/ecallurl.ASP?WCI=Interface&Function=SendPage&Address=+41791112233&Message=Hello%20World&AccountName=xxx&AccountPassword=yyy
there could be added the parameter "CallingNumber" (e.g. &CallingNumber=+41798887766) as sender number.
So you can see it's very straight forward.
I would really appreciate if someone could help. Would like to use 2FA feature in nextcloud with this provider.
Thanks in advance
Fabian
@ChristophWurst commented on GitHub (Jan 7, 2019):
Have a look at PRs like https://github.com/nextcloud/twofactor_gateway/pull/169. It's pretty easy to implement a custom gateway.
@FabianZihlmann commented on GitHub (Jan 8, 2019):
Take my chance after #169 has merged to master brunch
@FabianZihlmann commented on GitHub (Jan 8, 2019):
Tried my best with #182.
Unfortunately, I'm not really familliar with github, so I provided a patch for master branch.
Works on our productive Nextcloud-Installation.
Would be great if it could be integrated into the master branch.
Thanks so far
Fabian
@FabianZihlmann commented on GitHub (Jan 8, 2019):
Hi Christoph
Hope #182 is alright and you can review the code. Do I have to do anything else? Sorry for my asking, I'm quite new to github (read a lot of docs), so I'm not 100% sure.
Altough the committed code works perfect with our 15.0.0 productive installation.
@ChristophWurst commented on GitHub (Jan 8, 2019):
Thanks! I'll have a look now :)
@FabianZihlmann commented on GitHub (Jan 8, 2019):
solved by #185