[PR #45] [MERGED] Add UI to enable the app and verify the phone number #167

New issue

Closed

opened 2026-02-26 05:33:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 05:33:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nextcloud/twofactor_gateway/pull/45
Author: @ChristophWurst
Created: 4/11/2018
Status: ✅ Merged
Merged: 5/14/2018
Merged by: @ChristophWurst

Base: master ← Head: feature/phone-number-verification

📝 Commits (10+)

5c46126 Add setup class to verify the phone number
8624766 Only enable the provider for verified phone numbers
3e5a02f Merge branch 'master' into feature/phone-number-verification
87127e3 Make sure the phone number has been verified and it did not change
1a200fe Add npm, webpack and vue
b3e86fe Add UI mockup
d26725c Extrac l10n vue view
0562310 Add simple loading feedback
4307f2e Update package-lock.json
2e7cae6 Fix loading icon

📊 Changes

29 files changed (+11441 additions, -20 deletions)

View changed files

📝 .gitignore (+2 -0)
📝 appinfo/info.xml (+3 -0)
➕ appinfo/routes.php (+48 -0)
➕ js/init.js (+9 -0)
➕ js/service/registration.js (+55 -0)
➕ js/view/l10n.vue (+14 -0)
➕ js/view/settings.vue (+104 -0)
➕ js/webpack.base.config.js (+26 -0)
➕ js/webpack.dev.config.js (+7 -0)
➕ js/webpack.prod.config.js (+15 -0)
📝 lib/AppInfo/Application.php (+6 -1)
➕ lib/Controller/SettingsController.php (+114 -0)
➕ lib/Exception/PhoneNumberMismatchException.php (+31 -0)
➕ lib/Exception/PhoneNumberMissingException.php (+29 -0)
➕ lib/Exception/VerificationException.php (+29 -0)
➕ lib/Exception/VerificationTransmissionException.php (+29 -0)
➕ lib/PhoneNumberMask.php (+39 -0)
📝 lib/Provider/SmsProvider.php (+17 -15)
➕ lib/Provider/State.php (+49 -0)
➕ lib/Service/SetupService.php (+158 -0)

...and 9 more files

📄 Description

TODO

UI to send the verification message
UI to verify the received token
UI to show that this 2fa provider is enabled
Service module for the REST API
Server-side controller
Adjust provider to only enable when the number has been verified
Check phone number when sending the 2fa code every time and fail hard if it does not match the verified one
Handle error cases

Fixes https://github.com/ChristophWurst/twofactor_sms/issues/31

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nextcloud/twofactor_gateway/pull/45 **Author:** [@ChristophWurst](https://github.com/ChristophWurst) **Created:** 4/11/2018 **Status:** ✅ Merged **Merged:** 5/14/2018 **Merged by:** [@ChristophWurst](https://github.com/ChristophWurst) **Base:** `master` ← **Head:** `feature/phone-number-verification` --- ### 📝 Commits (10+) - [`5c46126`](https://github.com/nextcloud/twofactor_gateway/commit/5c461269f99359f24c4d31c817486af33dda3466) Add setup class to verify the phone number - [`8624766`](https://github.com/nextcloud/twofactor_gateway/commit/8624766999d64fdcc9adf91bcf3ecfe007d0dc0d) Only enable the provider for verified phone numbers - [`3e5a02f`](https://github.com/nextcloud/twofactor_gateway/commit/3e5a02ff45b4e96f096964985f80aa206c3e69af) Merge branch 'master' into feature/phone-number-verification - [`87127e3`](https://github.com/nextcloud/twofactor_gateway/commit/87127e3f043f531729ac9ea49d97416407c22914) Make sure the phone number has been verified and it did not change - [`1a200fe`](https://github.com/nextcloud/twofactor_gateway/commit/1a200fe6bf8e97accd63bb6f8e732bb01ab4fa50) Add npm, webpack and vue - [`b3e86fe`](https://github.com/nextcloud/twofactor_gateway/commit/b3e86fe2e8b6309b2c476726a79021b2f774482e) Add UI mockup - [`d26725c`](https://github.com/nextcloud/twofactor_gateway/commit/d26725ca97ba0d30de67a99317f524275df5feb7) Extrac l10n vue view - [`0562310`](https://github.com/nextcloud/twofactor_gateway/commit/0562310200978d1a4a70d51e46c5503721d65c32) Add simple loading feedback - [`4307f2e`](https://github.com/nextcloud/twofactor_gateway/commit/4307f2eaa861c5677a4b5d5f93855598f9e73961) Update package-lock.json - [`2e7cae6`](https://github.com/nextcloud/twofactor_gateway/commit/2e7cae618a98d6e75365fc897be62fc3e7832a7a) Fix loading icon ### 📊 Changes **29 files changed** (+11441 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -0) 📝 `appinfo/info.xml` (+3 -0) ➕ `appinfo/routes.php` (+48 -0) ➕ `js/init.js` (+9 -0) ➕ `js/service/registration.js` (+55 -0) ➕ `js/view/l10n.vue` (+14 -0) ➕ `js/view/settings.vue` (+104 -0) ➕ `js/webpack.base.config.js` (+26 -0) ➕ `js/webpack.dev.config.js` (+7 -0) ➕ `js/webpack.prod.config.js` (+15 -0) 📝 `lib/AppInfo/Application.php` (+6 -1) ➕ `lib/Controller/SettingsController.php` (+114 -0) ➕ `lib/Exception/PhoneNumberMismatchException.php` (+31 -0) ➕ `lib/Exception/PhoneNumberMissingException.php` (+29 -0) ➕ `lib/Exception/VerificationException.php` (+29 -0) ➕ `lib/Exception/VerificationTransmissionException.php` (+29 -0) ➕ `lib/PhoneNumberMask.php` (+39 -0) 📝 `lib/Provider/SmsProvider.php` (+17 -15) ➕ `lib/Provider/State.php` (+49 -0) ➕ `lib/Service/SetupService.php` (+158 -0) _...and 9 more files_ </details> ### 📄 Description TODO - [x] UI to send the verification message - [x] UI to verify the received token - [x] UI to show that this 2fa provider is enabled - [x] Service module for the REST API - [x] Server-side controller - [x] Adjust provider to only enable when the number has been verified - [x] Check phone number when sending the 2fa code every time and fail hard if it does not match the verified one - [x] Handle error cases Fixes https://github.com/ChristophWurst/twofactor_sms/issues/31 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 05:33:47 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 05:34:13 +03:00

[PR #167] [CLOSED] Bump webpack from 4.26.0 to 4.28.2 #261

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/twofactor_gateway-nextcloud#167

No description provided.

Rows
Columns