[PR #78] [MERGED] Make provider stateful #194

New issue

Closed

opened 2026-02-26 05:33:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 05:33:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nextcloud/twofactor_gateway/pull/78
Author: @ChristophWurst
Created: 8/6/2018
Status: ✅ Merged
Merged: 8/7/2018
Merged by: @ChristophWurst

Base: master ← Head: fix/provider-state-propagation

📝 Commits (5)

5a90c2a Refactor class structure to resolve cyclic dependencies
ce19d74 Refactor provider to not use the config ojbect directly
8896b8a Fix cyclic dependency
11e2821 Fix state propagation for the provider registry
9100f8c Update OCP lib

📊 Changes

11 files changed (+624 additions, -126 deletions)

View changed files

📝 composer.lock (+4 -4)
📝 lib/Controller/SettingsController.php (+2 -2)
📝 lib/Provider/SmsProvider.php (+30 -24)
📝 lib/Provider/State.php (+86 -7)
📝 lib/Service/IGateway.php (+3 -1)
📝 lib/Service/SetupService.php (+39 -32)
➕ lib/Service/StateStorage.php (+134 -0)
📝 tests/Unit/Provider/SmsProviderTest.php (+31 -14)
➕ tests/Unit/Provider/StateTest.php (+53 -0)
📝 tests/Unit/Service/SetupServiceTest.php (+74 -42)
➕ tests/Unit/Service/StateStorageTest.php (+168 -0)

📄 Description

Ref https://github.com/ChristophWurst/twofactor_gateway/projects/1#card-11846348

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nextcloud/twofactor_gateway/pull/78 **Author:** [@ChristophWurst](https://github.com/ChristophWurst) **Created:** 8/6/2018 **Status:** ✅ Merged **Merged:** 8/7/2018 **Merged by:** [@ChristophWurst](https://github.com/ChristophWurst) **Base:** `master` ← **Head:** `fix/provider-state-propagation` --- ### 📝 Commits (5) - [`5a90c2a`](https://github.com/nextcloud/twofactor_gateway/commit/5a90c2a51adce307a8451f7957df8a27aa581dba) Refactor class structure to resolve cyclic dependencies - [`ce19d74`](https://github.com/nextcloud/twofactor_gateway/commit/ce19d74b9854b518484dc88a24b7258aa8a068f4) Refactor provider to not use the config ojbect directly - [`8896b8a`](https://github.com/nextcloud/twofactor_gateway/commit/8896b8a0448224580bf5cff20c27cc8d38218d13) Fix cyclic dependency - [`11e2821`](https://github.com/nextcloud/twofactor_gateway/commit/11e2821263d06a6ffc2aeb7e7b0d1a8d8c4e60ba) Fix state propagation for the provider registry - [`9100f8c`](https://github.com/nextcloud/twofactor_gateway/commit/9100f8c53981ca740c0ffaf477ada8dc21206dea) Update OCP lib ### 📊 Changes **11 files changed** (+624 additions, -126 deletions) <details> <summary>View changed files</summary> 📝 `composer.lock` (+4 -4) 📝 `lib/Controller/SettingsController.php` (+2 -2) 📝 `lib/Provider/SmsProvider.php` (+30 -24) 📝 `lib/Provider/State.php` (+86 -7) 📝 `lib/Service/IGateway.php` (+3 -1) 📝 `lib/Service/SetupService.php` (+39 -32) ➕ `lib/Service/StateStorage.php` (+134 -0) 📝 `tests/Unit/Provider/SmsProviderTest.php` (+31 -14) ➕ `tests/Unit/Provider/StateTest.php` (+53 -0) 📝 `tests/Unit/Service/SetupServiceTest.php` (+74 -42) ➕ `tests/Unit/Service/StateStorageTest.php` (+168 -0) </details> ### 📄 Description Ref https://github.com/ChristophWurst/twofactor_gateway/projects/1#card-11846348 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 05:33:55 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 05:34:21 +03:00

[PR #194] [MERGED] Bump webpack from 4.29.0 to 4.29.1 #283

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/twofactor_gateway-nextcloud#194

No description provided.

Rows
Columns