mirror of
https://github.com/nextcloud/twofactor_gateway.git
synced 2026-04-27 01:55:52 +03:00
[GH-ISSUE #491] Using the app to send SMS for other purposes #105
Labels
No labels
0. to triage
1. to develop
3. to review
blocked
bug
discussion
duplicate
enhancement
enhancement
gateway:signal
gateway:signal
gateway:signal
gateway:sms
gateway:telegram
hacktoberfest
help wanted
invalid
needs info
php
pull-request
question
technical debt
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/twofactor_gateway-nextcloud#105
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @StCyr on GitHub (Apr 11, 2022).
Original GitHub issue: https://github.com/nextcloud/twofactor_gateway/issues/491
Hello, I'm looking for an app to send SMS for other purposes than logging in.
It looks like this app would do the trick if I could use the OCA\Service\Gateay\SMS\Gateway class from other apps.
I know using classes from the OCA namespace is generaly not advised but, hey, what are my other choices? ;-)
@vitormattos commented on GitHub (Apr 11, 2022):
You can use this class but if this class is modified, maybe can break your code.
A solution is contributing with development of this app making the code base best and more stable.
@StCyr commented on GitHub (Apr 11, 2022):
Yes, I can help maintaining this app.
The question is how can I do anything better than using the class from the OCA namespace? I think the only solution is to create an interface in the OCP namespace (hence in nextcloud/server). Am I right?
@vitormattos commented on GitHub (Apr 12, 2022):
I think that creating an interface in the OCP namespace will be hardy. Imagine the scenario when all app need to implement interface on server repository?
The problem is that you will need follow and help to development of this app to maintain him compatible with your app.