[PR #449] [MERGED] Add NC 21/22 and PHP 8 support #491

New issue

Closed

opened 2026-02-26 06:31:01 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 06:31:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/nextcloud/twofactor_gateway/pull/449
Author: @seyfahni
Created: 6/3/2021
Status: ✅ Merged
Merged: 6/11/2021
Merged by: @ChristophWurst

Base: master ← Head: php8-nc21

📝 Commits (9)

a0b5a1a Add NC 21 and PHP 8 Support
3ea906d Update NC and PHP Version, and Travis Config
0f6853e Ignore PhpStorm project files.
459bcd8 Upgrade composer dependencies to work with PHP 8.
5d67d63 Fix issues found by php-cs.
4ae72ae Force usage of minimal possible PHP version.
27eb87c Update non-breaking node dependencies.
e9c04cb Update travis config.
37e25c0 Ignore php-cs config and PhpStorm project files when packaging with krankerl.

📊 Changes

29 files changed (+6767 additions, -3171 deletions)

View changed files

📝 .gitignore (+2 -0)
📝 .nextcloudignore (+2 -0)
📝 .php-cs-fixer.dist.php (+0 -0)
📝 .travis.yml (+27 -29)
📝 appinfo/info.xml (+3 -3)
📝 composer.json (+7 -4)
📝 composer.lock (+1441 -1881)
📝 lib/Command/Remove.php (+1 -1)
📝 lib/Service/Gateway/SMS/Provider/ClickSendConfig.php (+11 -5)
📝 lib/Service/Gateway/SMS/Provider/ClickatellCentralConfig.php (+2 -3)
📝 lib/Service/Gateway/SMS/Provider/ClockworkSMSConfig.php (+2 -3)
📝 lib/Service/Gateway/SMS/Provider/EcallSMSConfig.php (+2 -3)
📝 lib/Service/Gateway/SMS/Provider/HuaweiE3531Config.php (+2 -3)
📝 lib/Service/Gateway/SMS/Provider/IProviderConfig.php (+1 -0)
📝 lib/Service/Gateway/SMS/Provider/Ovh.php (+21 -21)
📝 lib/Service/Gateway/SMS/Provider/OvhConfig.php (+2 -3)
📝 lib/Service/Gateway/SMS/Provider/PlaySMSConfig.php (+2 -3)
📝 lib/Service/Gateway/SMS/Provider/PuzzelSMS.php (+1 -1)
📝 lib/Service/Gateway/SMS/Provider/PuzzelSMSConfig.php (+2 -3)
📝 lib/Service/Gateway/SMS/Provider/Sms77IoConfig.php (+2 -3)

...and 9 more files

📄 Description

This PR is based on #438, but addresses some additional issues:

Cleaned up composer dependencies, so that composer update works with all PHP versions from 7.2 up to 8.0
Cleaned up and fixed TravisCI builds (but for travis-ci.com, so the project can migrate)
Added files to .nextcloudignore that shouldn't be part of releases
Updated non-breaking node.js dependencies (closing some vulnerabilities too)
Fixed php-cs findings

Replaces #438.
Fixes #426 and fixes #425.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/nextcloud/twofactor_gateway/pull/449 **Author:** [@seyfahni](https://github.com/seyfahni) **Created:** 6/3/2021 **Status:** ✅ Merged **Merged:** 6/11/2021 **Merged by:** [@ChristophWurst](https://github.com/ChristophWurst) **Base:** `master` ← **Head:** `php8-nc21` --- ### 📝 Commits (9) - [`a0b5a1a`](https://github.com/nextcloud/twofactor_gateway/commit/a0b5a1a01c4e1f448934b1c49cd692c1847c41e1) Add NC 21 and PHP 8 Support - [`3ea906d`](https://github.com/nextcloud/twofactor_gateway/commit/3ea906d85fa6f6d10c2ae8225c48a0ba4808a887) Update NC and PHP Version, and Travis Config - [`0f6853e`](https://github.com/nextcloud/twofactor_gateway/commit/0f6853e87db0b88c24bc4ed316e272bd67869009) Ignore PhpStorm project files. - [`459bcd8`](https://github.com/nextcloud/twofactor_gateway/commit/459bcd83a7be79fe7568cd312cdddafcfae49824) Upgrade composer dependencies to work with PHP 8. - [`5d67d63`](https://github.com/nextcloud/twofactor_gateway/commit/5d67d632c73903b8cd97f5330d5175fc6368adae) Fix issues found by php-cs. - [`4ae72ae`](https://github.com/nextcloud/twofactor_gateway/commit/4ae72ae86e8296ef539c464aa0f597a424e5b680) Force usage of minimal possible PHP version. - [`27eb87c`](https://github.com/nextcloud/twofactor_gateway/commit/27eb87c24ecefceab815516d7f4cfb3103c9fbbf) Update non-breaking node dependencies. - [`e9c04cb`](https://github.com/nextcloud/twofactor_gateway/commit/e9c04cb3b1a4a71059a57a644ff28cefeb0f4464) Update travis config. - [`37e25c0`](https://github.com/nextcloud/twofactor_gateway/commit/37e25c03ed641b10c5c794a084a4b6c19f14fff7) Ignore php-cs config and PhpStorm project files when packaging with krankerl. ### 📊 Changes **29 files changed** (+6767 additions, -3171 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -0) 📝 `.nextcloudignore` (+2 -0) 📝 `.php-cs-fixer.dist.php` (+0 -0) 📝 `.travis.yml` (+27 -29) 📝 `appinfo/info.xml` (+3 -3) 📝 `composer.json` (+7 -4) 📝 `composer.lock` (+1441 -1881) 📝 `lib/Command/Remove.php` (+1 -1) 📝 `lib/Service/Gateway/SMS/Provider/ClickSendConfig.php` (+11 -5) 📝 `lib/Service/Gateway/SMS/Provider/ClickatellCentralConfig.php` (+2 -3) 📝 `lib/Service/Gateway/SMS/Provider/ClockworkSMSConfig.php` (+2 -3) 📝 `lib/Service/Gateway/SMS/Provider/EcallSMSConfig.php` (+2 -3) 📝 `lib/Service/Gateway/SMS/Provider/HuaweiE3531Config.php` (+2 -3) 📝 `lib/Service/Gateway/SMS/Provider/IProviderConfig.php` (+1 -0) 📝 `lib/Service/Gateway/SMS/Provider/Ovh.php` (+21 -21) 📝 `lib/Service/Gateway/SMS/Provider/OvhConfig.php` (+2 -3) 📝 `lib/Service/Gateway/SMS/Provider/PlaySMSConfig.php` (+2 -3) 📝 `lib/Service/Gateway/SMS/Provider/PuzzelSMS.php` (+1 -1) 📝 `lib/Service/Gateway/SMS/Provider/PuzzelSMSConfig.php` (+2 -3) 📝 `lib/Service/Gateway/SMS/Provider/Sms77IoConfig.php` (+2 -3) _...and 9 more files_ </details> ### 📄 Description This PR is based on #438, but addresses some additional issues: - Cleaned up composer dependencies, so that `composer update` works with all PHP versions from 7.2 up to 8.0 - Cleaned up and fixed TravisCI builds (but for travis-ci.com, so the project can migrate) - Added files to `.nextcloudignore` that shouldn't be part of releases - Updated non-breaking node.js dependencies (closing some vulnerabilities too) - Fixed php-cs findings Replaces #438. Fixes #426 and fixes #425. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 06:31:01 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/twofactor_gateway-nextcloud#491

No description provided.

Rows
Columns