[PR #423] [CLOSED] implement modal_input - like js 'prompt' primitive #946

Closed
opened 2026-03-04 01:08:41 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/rivo/tview/pull/423
Author: @holiman
Created: 3/30/2020
Status: Closed

Base: masterHead: modal_input


📝 Commits (1)

  • b13187d implement modal_input - like js 'prompt' primitive

📊 Changes

4 files changed (+219 additions, -0 deletions)

View changed files

demos/modal_input/README.md (+1 -0)
demos/modal_input/main.go (+26 -0)
demos/modal_input/screenshot.png (+0 -0)
modal_input.go (+192 -0)

📄 Description

This PR implements another modal primitive, similar to javascript prompt method. I'm a bit new to tview, and I'm not quite sure if things like this belong in the upstream library or if they are expected to be written in the upper layer. However, it seemed natural to make it similar to the existing modal windows. Please let me know if I've missed some easier way to achieve the same goal.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/rivo/tview/pull/423 **Author:** [@holiman](https://github.com/holiman) **Created:** 3/30/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `modal_input` --- ### 📝 Commits (1) - [`b13187d`](https://github.com/rivo/tview/commit/b13187dceab9601811d36a2bc9f865e3c1df5ab0) implement modal_input - like js 'prompt' primitive ### 📊 Changes **4 files changed** (+219 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `demos/modal_input/README.md` (+1 -0) ➕ `demos/modal_input/main.go` (+26 -0) ➕ `demos/modal_input/screenshot.png` (+0 -0) ➕ `modal_input.go` (+192 -0) </details> ### 📄 Description This PR implements another modal primitive, similar to javascript `prompt` method. I'm a bit new to tview, and I'm not quite sure if things like this belong in the upstream library or if they are expected to be written in the upper layer. However, it seemed natural to make it similar to the existing `modal` windows. Please let me know if I've missed some easier way to achieve the same goal. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 01:08:41 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tview#946
No description provided.