[PR #955] [CLOSED] Fixed rendering for list selected item when reverse attribute is part of selected style #1080

New issue

Closed

opened 2026-03-04 01:09:20 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 01:09:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rivo/tview/pull/955
Author: @Souheab
Created: 3/7/2024
Status: ❌ Closed

Base: master ← Head: patch1

📝 Commits (5)

6744443 Fixed an infinite loop after clearing a selected cell. Fixes #944
ec2e237 Mouse scrolling to the end turns tracking on. Resolves #945
ae2f149 No mouse scrolling when scrolling is turned off.
e2bf3e8 Drawing the Box in Modal, not in contained Frame. Fixes #946
5eebffb Fixed list selected style not being applied in a desirable way when reverse attribute is part of the style

📊 Changes

4 files changed (+26 additions, -9 deletions)

View changed files

📝 list.go (+4 -3)
📝 modal.go (+4 -3)
📝 table.go (+2 -2)
📝 textview.go (+16 -1)

📄 Description

Attempt to fix issue #954

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rivo/tview/pull/955 **Author:** [@Souheab](https://github.com/Souheab) **Created:** 3/7/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch1` --- ### 📝 Commits (5) - [`6744443`](https://github.com/rivo/tview/commit/6744443e123e2680eb4f49b6a76c77b2684fa2df) Fixed an infinite loop after clearing a selected cell. Fixes #944 - [`ec2e237`](https://github.com/rivo/tview/commit/ec2e237621890cfd0b22fc32f5c78233509b2329) Mouse scrolling to the end turns tracking on. Resolves #945 - [`ae2f149`](https://github.com/rivo/tview/commit/ae2f14990b4c14cb589ba41ec3e3dc949eea18f5) No mouse scrolling when scrolling is turned off. - [`e2bf3e8`](https://github.com/rivo/tview/commit/e2bf3e8a15a1e959a50a83241a66c1c4e43f2a1e) Drawing the Box in Modal, not in contained Frame. Fixes #946 - [`5eebffb`](https://github.com/rivo/tview/commit/5eebffbce45094fba6212c353ba2c0e3d4420cc7) Fixed list selected style not being applied in a desirable way when reverse attribute is part of the style ### 📊 Changes **4 files changed** (+26 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `list.go` (+4 -3) 📝 `modal.go` (+4 -3) 📝 `table.go` (+2 -2) 📝 `textview.go` (+16 -1) </details> ### 📄 Description Attempt to fix issue #954 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>