mirror of
https://github.com/rivo/tview.git
synced 2026-04-26 21:35:54 +03:00
[GH-ISSUE #123] Feature: Borders like Styles #94
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tview#94
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @benweidig on GitHub (May 26, 2018).
Original GitHub issue: https://github.com/rivo/tview/issues/123
Hi,
great library!
I would like to change the rune used for borders, similiar to the Styles in style.go
As a precursor I fixed a mixup in box.go and added comments with the unicode to the current constants #126
If you think it's a good idea to have a
var Borderslikevar StylesI could prepare another pull request with the feature, defaulting to the current border runes.@benweidig commented on GitHub (May 27, 2018):
After starting with this feature I realised that just replacing border runes isn't enough to support all widgets/features.
Instead it looks like I'm going refactor all the semigraphics stuff from utils.go to its own space, and add a border/joints logic on top of it.
@rivo commented on GitHub (Jun 15, 2018):
I'm closing this now as I just merged #126.