[GH-ISSUE #155] BUG(maybe): full row selection not implement full row #123

Closed
opened 2026-03-04 01:02:09 +03:00 by kerem · 5 comments
Owner

Originally created by @askovpen on GitHub (Aug 8, 2018).
Original GitHub issue: https://github.com/rivo/tview/issues/155

image

light-blue - table border. maybe full row selection need from leftborder to right border?

Originally created by @askovpen on GitHub (Aug 8, 2018). Original GitHub issue: https://github.com/rivo/tview/issues/155 ![image](https://user-images.githubusercontent.com/1572969/43859067-58b86cc2-9b58-11e8-811b-72078df40c08.png) light-blue - table border. maybe full row selection need from leftborder to right border?
kerem closed this issue 2026-03-04 01:02:09 +03:00
Author
Owner

@rivo commented on GitHub (Aug 12, 2018):

I'm sorry but I don't understand what you are asking here. Could you include a short code snippet that illustrates the problem?

<!-- gh-comment-id:412358189 --> @rivo commented on GitHub (Aug 12, 2018): I'm sorry but I don't understand what you are asking here. Could you include a short code snippet that illustrates the problem?
Author
Owner

@askovpen commented on GitHub (Aug 12, 2018):

selection bar have not full row. only where text.

<!-- gh-comment-id:412358570 --> @askovpen commented on GitHub (Aug 12, 2018): selection bar have not full row. only where text.
Author
Owner

@rivo commented on GitHub (Aug 17, 2018):

Please provide some example code. It's not clear to me what your problem is.

<!-- gh-comment-id:413962087 --> @rivo commented on GitHub (Aug 17, 2018): Please provide some example code. It's not clear to me what your problem is.
Author
Owner

@joegrasse commented on GitHub (Aug 20, 2018):

@rivo Maybe what @askovpen is trying to say is that they want the highlight on the row to go from the left blue border to the right blue border. Not sure why you would want that. Seems better to have the table fill the box width.

<!-- gh-comment-id:414299209 --> @joegrasse commented on GitHub (Aug 20, 2018): @rivo Maybe what @askovpen is trying to say is that they want the highlight on the row to go from the left blue border to the right blue border. Not sure why you would want that. Seems better to have the table fill the box width.
Author
Owner

@rivo commented on GitHub (Aug 21, 2018):

Thanks for pointing this out. I would say that if one wants to extend the highlight, there are ways to do that, e.g. use SetExpansion() on the last column (but it might cause problems with alignment) or create another, "invisible" column with SetExpansion() set to 1. But I agree that doing this by default is not what everybody would want.

<!-- gh-comment-id:414692825 --> @rivo commented on GitHub (Aug 21, 2018): Thanks for pointing this out. I would say that if one wants to extend the highlight, there are ways to do that, e.g. use [`SetExpansion()`](https://godoc.org/github.com/rivo/tview#TableCell.SetExpansion) on the last column (but it might cause problems with alignment) or create another, "invisible" column with [`SetExpansion()`](https://godoc.org/github.com/rivo/tview#TableCell.SetExpansion) set to 1. But I agree that doing this by default is not what everybody would want.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tview#123
No description provided.