starred/tview

Fork 0

mirror of https://github.com/rivo/tview.git synced 2026-04-26 21:35:54 +03:00

[GH-ISSUE #94] Feature Request: Improve method of retrieving form input #74

New issue

Closed

opened 2026-03-04 01:01:41 +03:00 by kerem · 9 comments

kerem commented

2026-03-04 01:01:41 +03:00

Owner

Originally created by @joegrasse on GitHub (Mar 30, 2018).
Original GitHub issue: https://github.com/rivo/tview/issues/94

It would be a lot easier to work with forms if you could get the input by name.

For example

firstname := form.GetFormItemByName("firstname").(*tview.InputField).GetText()

Originally created by @joegrasse on GitHub (Mar 30, 2018). Original GitHub issue: https://github.com/rivo/tview/issues/94 It would be a lot easier to work with forms if you could get the input by name. For example ```Go firstname := form.GetFormItemByName("firstname").(*tview.InputField).GetText() ```

kerem closed this issue

2026-03-04 01:01:41 +03:00

kerem commented

2026-03-04 01:01:42 +03:00

Author

Owner

@rivo commented on GitHub (Apr 1, 2018):

I don't know. I guess. But the way it is now, I'd either have to duplicate a whole bunch of Form methods or break backwards compatibility to achieve this (i.e. by adding a name parameter to all Add methods).

I would suggest that you do this:

firstName := tview.NewInputField()
form.AddFormItem(firstName)

Then you can always reference it by its actual variable firstName and you don't even have to cast it:

name := firstName.GetText()

If it's just about getting the input field's text, I usually use the event callback to update its string variable:

form.AddInputField("First name", "", 30, nil, func(text string) {
	name = text
})

Would this help you?

@rivo commented on GitHub (Apr 1, 2018): I don't know. I guess. But the way it is now, I'd either have to duplicate a whole bunch of `Form` methods or break backwards compatibility to achieve this (i.e. by adding a name parameter to all `Add` methods). I would suggest that you do this: ```go firstName := tview.NewInputField() form.AddFormItem(firstName) ``` Then you can always reference it by its actual variable `firstName` and you don't even have to cast it: ```go name := firstName.GetText() ``` If it's just about getting the input field's text, I usually use the event callback to update its string variable: ```go form.AddInputField("First name", "", 30, nil, func(text string) { name = text }) ``` Would this help you?

kerem commented

2026-03-04 01:01:42 +03:00

Author

Owner

@joegrasse commented on GitHub (Apr 1, 2018):

Yes, that is what I do now in the form.AddButton("Save", func() { section. This makes it hard to break the code out that performs the save functionality though. I would have to pass all of the form items to the function, or do firstname := form.GetFormItem(0).(*tview.InputField).GetText(). As you can see, 0 mapping to firstname isn't quite obvious.

Also, I guess what I really meant was firstname := form.GetFormItemByLabel("firstname").(*tview.InputField).GetText(). This wouldn't break backwards compatibility, since the Add* methods have a label.

@joegrasse commented on GitHub (Apr 1, 2018): Yes, that is what I do now in the ```form.AddButton("Save", func() {``` section. This makes it hard to break the code out that performs the save functionality though. I would have to pass all of the form items to the function, or do ```firstname := form.GetFormItem(0).(*tview.InputField).GetText()```. As you can see, 0 mapping to firstname isn't quite obvious. Also, I guess what I really meant was ```firstname := form.GetFormItemByLabel("firstname").(*tview.InputField).GetText()```. This wouldn't break backwards compatibility, since the Add* methods have a label.

kerem commented

2026-03-04 01:01:42 +03:00

Author

Owner

@rivo commented on GitHub (Apr 5, 2018):

Yeah, that's what I was going to offer you. I hope I'll have this for you tomorrow at the latest.

@rivo commented on GitHub (Apr 5, 2018): Yeah, that's what I was going to offer you. I hope I'll have this for you tomorrow at the latest.

kerem commented

2026-03-04 01:01:42 +03:00

Author

Owner

@joegrasse commented on GitHub (Apr 5, 2018):

Awesome. Thank you.

@joegrasse commented on GitHub (Apr 5, 2018): Awesome. Thank you.

kerem commented

2026-03-04 01:01:42 +03:00

Author

Owner

@rivo commented on GitHub (Apr 7, 2018):

Have a look, it's there now.

@rivo commented on GitHub (Apr 7, 2018): Have a look, it's there now.

kerem commented

2026-03-04 01:01:42 +03:00

Author

Owner

@joegrasse commented on GitHub (Apr 8, 2018):

Thanks again.

@joegrasse commented on GitHub (Apr 8, 2018): Thanks again.

kerem commented

2026-03-04 01:01:42 +03:00

Author

Owner

@joegrasse commented on GitHub (Apr 9, 2018):

@rivo I have been testing out your changes and have ran into an issue. After the form has been drawn, the label can change. As-in, it can have spaces added to it to line up all of the input boxes. Here you are updating the item attributes and above you are adding spaces to the label if needed. So the label doesn't always match what you set it to, which make GetFormItemByLabel hard to use at the moment.

@joegrasse commented on GitHub (Apr 9, 2018): @rivo I have been testing out your changes and have ran into an issue. After the form has been drawn, the label can change. As-in, it can have spaces added to it to line up all of the input boxes. [Here](https://github.com/rivo/tview/blob/cc84c982fc1fc91616feb488f80725fdcb76c266/form.go#L323) you are updating the item attributes and [above](https://github.com/rivo/tview/blob/cc84c982fc1fc91616feb488f80725fdcb76c266/form.go#L308) you are adding spaces to the label if needed. So the label doesn't always match what you set it to, which make ```GetFormItemByLabel``` hard to use at the moment.

kerem commented

2026-03-04 01:01:42 +03:00

Author

Owner

@joegrasse commented on GitHub (Apr 9, 2018):

@rivo Created pull request to fix my issue.

@joegrasse commented on GitHub (Apr 9, 2018): @rivo Created pull request to fix my issue.

kerem commented

2026-03-04 01:01:42 +03:00

Author

Owner

@rivo commented on GitHub (Apr 9, 2018):