[GH-ISSUE #323] Getting a selectionChanged notify when application uses Table.Select() #244

New issue

Closed

opened 2026-03-04 01:03:18 +03:00 by kerem · 1 comment

kerem commented

2026-03-04 01:03:18 +03:00

Owner

Originally created by @pktgen on GitHub (Jul 19, 2019).
Original GitHub issue: https://github.com/rivo/tview/issues/323

Using a Table if I move the selected row/col via keyboard and I have the SetSelectionChangedFunc() the callback works great.

In my case I need to remove or add items to the table. This may mean the I need to change the selected row/col in the application. It would be nice to get a notification or callback called when I call the Table.Select() function.

I could not find anything in the docs about getting some callback for this type of event. As a test I went into the Table.Select() function and modified it to do this:

func (t *Table) Select(row, column int) *Table {
      t.selectedRow, t.selectedColumn = row, column

       // If the selection has changed, notify the handler.
       if t.selectionChanged != nil &&
               (t.rowsSelectable || t.columnsSelectable) {
               t.selectionChanged(t.selectedRow, t.selectedColumn)
       }
       return t
}

Do you think this is a reasonable change to get a notify call when the application moves to a different cell?

BTW, excellent package :-)

Originally created by @pktgen on GitHub (Jul 19, 2019). Original GitHub issue: https://github.com/rivo/tview/issues/323 Using a Table if I move the selected row/col via keyboard and I have the SetSelectionChangedFunc() the callback works great. In my case I need to remove or add items to the table. This may mean the I need to change the selected row/col in the application. It would be nice to get a notification or callback called when I call the Table.Select() function. I could not find anything in the docs about getting some callback for this type of event. As a test I went into the Table.Select() function and modified it to do this: ```go func (t *Table) Select(row, column int) *Table { t.selectedRow, t.selectedColumn = row, column // If the selection has changed, notify the handler. if t.selectionChanged != nil && (t.rowsSelectable || t.columnsSelectable) { t.selectionChanged(t.selectedRow, t.selectedColumn) } return t } ``` Do you think this is a reasonable change to get a notify call when the application moves to a different cell? BTW, excellent package :-)

kerem closed this issue

2026-03-04 01:03:18 +03:00

kerem commented

2026-03-04 01:03:19 +03:00

Author

Owner

@rivo commented on GitHub (Jul 21, 2019):

Thanks for catching this. It should have triggered this event all along. The latest commit fixes this.

@rivo commented on GitHub (Jul 21, 2019): Thanks for catching this. It should have triggered this event all along. The latest commit fixes this.

kerem referenced this issue

2026-03-04 01:05:02 +03:00

[GH-ISSUE #597] app.Stop() and app.Suspend() require an additional keypress before clearing screen #437