[PR #361] [MERGED] fix settings are not saved. #963

New issue

Closed

opened 2026-03-02 16:02:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 16:02:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/prasathmani/tinyfilemanager/pull/361
Author: @rinoshiyo
Created: 5/17/2020
Status: ✅ Merged
Merged: 5/18/2020
Merged by: @prasathmani

Base: master ← Head: fix-350

📝 Commits (1)

71b3c8f fix settings are not saved.

📊 Changes

1 file changed (+2 additions, -3 deletions)

View changed files

📝 tinyfilemanager.php (+2 -3)

📄 Description

Changed to use __FILE__ instead of $root_path.$_SERVER["PHP_SELF"] to get its own filename.
In addition, since the existence of its own file is explicit, so I use is_writable() instead of file_exists().

Probably, #350 can be solved.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/prasathmani/tinyfilemanager/pull/361 **Author:** [@rinoshiyo](https://github.com/rinoshiyo) **Created:** 5/17/2020 **Status:** ✅ Merged **Merged:** 5/18/2020 **Merged by:** [@prasathmani](https://github.com/prasathmani) **Base:** `master` ← **Head:** `fix-350` --- ### 📝 Commits (1) - [`71b3c8f`](https://github.com/prasathmani/tinyfilemanager/commit/71b3c8f7adcdacdeae4876c2edd63528c4ff65d1) fix settings are not saved. ### 📊 Changes **1 file changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `tinyfilemanager.php` (+2 -3) </details> ### 📄 Description Changed to use \_\_FILE\_\_ instead of $root_path.$_SERVER["PHP_SELF"] to get its own filename. In addition, since the existence of its own file is explicit, so I use is_writable() instead of file_exists(). Probably, #350 can be solved. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>