[PR #89] [MERGED] show error on on lading page for insecure contexts #91

New issue

Closed

opened 2026-03-03 01:21:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:21:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cs01/termpair/pull/89
Author: @cs01
Created: 8/31/2021
Status: ✅ Merged
Merged: 8/31/2021
Merged by: @cs01

Base: master ← Head: cs01/show-error-on-insecure-context

📝 Commits (1)

9ae2b40 show error on on lading page for insecure contexts

📊 Changes

7 files changed (+113 additions, -61 deletions)

View changed files

➕ .vscode/extensions.json (+3 -0)
📝 .vscode/settings.json (+4 -0)
📝 CHANGELOG.md (+52 -43)
📝 termpair/constants.py (+1 -1)
📝 termpair/frontend_src/src/App.tsx (+12 -5)
📝 termpair/frontend_src/src/LandingPageContent.tsx (+29 -11)
📝 termpair/frontend_src/src/constants.tsx (+12 -1)

📄 Description

I have added an entry to CHANGELOG.md

Summary of changes

Test plan

Tested by showing error unconditionally and running

make watch_frontend

to confirm red box shows up in UI.

I also built and shared to make sure the logic worked right

make build_frontend
nox -s serve
nox -s share -- --host http://0.0.0.0

This is what it looks like

The changelog got autoformatted by VS Code but it should still render the same output.
fixes #88

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cs01/termpair/pull/89 **Author:** [@cs01](https://github.com/cs01) **Created:** 8/31/2021 **Status:** ✅ Merged **Merged:** 8/31/2021 **Merged by:** [@cs01](https://github.com/cs01) **Base:** `master` ← **Head:** `cs01/show-error-on-insecure-context` --- ### 📝 Commits (1) - [`9ae2b40`](https://github.com/cs01/termpair/commit/9ae2b408eea93f51313a194fea06bdb6914e2fbf) show error on on lading page for insecure contexts ### 📊 Changes **7 files changed** (+113 additions, -61 deletions) <details> <summary>View changed files</summary> ➕ `.vscode/extensions.json` (+3 -0) 📝 `.vscode/settings.json` (+4 -0) 📝 `CHANGELOG.md` (+52 -43) 📝 `termpair/constants.py` (+1 -1) 📝 `termpair/frontend_src/src/App.tsx` (+12 -5) 📝 `termpair/frontend_src/src/LandingPageContent.tsx` (+29 -11) 📝 `termpair/frontend_src/src/constants.tsx` (+12 -1) </details> ### 📄 Description  * [x] I have added an entry to `CHANGELOG.md` ## Summary of changes ## Test plan  Tested by showing error unconditionally and running ``` make watch_frontend ``` to confirm red box shows up in UI. I also built and shared to make sure the logic worked right ``` make build_frontend nox -s serve nox -s share -- --host http://0.0.0.0 ``` This is what it looks like ![image](https://user-images.githubusercontent.com/5715368/131532935-041a1c8d-7eae-4b64-8e28-8330826cf3d0.png) The changelog got autoformatted by VS Code but it should still render the same output. fixes #88 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>