[PR #84] [MERGED] require subparser command #89

New issue

Closed

opened 2026-03-03 01:21:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:21:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cs01/termpair/pull/84
Author: @cs01
Created: 8/23/2021
Status: ✅ Merged
Merged: 8/23/2021
Merged by: @cs01

Base: master ← Head: cs01/require-command

📝 Commits (1)

ea0d406 require subparser command

📊 Changes

5 files changed (+9 additions, -6 deletions)

View changed files

📝 CHANGELOG.md (+3 -0)
📝 noxfile.py (+3 -3)
📝 termpair/constants.py (+1 -1)
📝 termpair/frontend_src/src/constants.ts (+1 -1)
📝 termpair/main.py (+1 -1)

📄 Description

I have added an entry to CHANGELOG.md

Summary of changes

Require subcommand so the CLI is not confusing if serve or share is not entered. Instead of silently exiting successfully and not doing anything, an error is raised to tell the user they need to enter a subcommand.

Test plan

before

> nox -s build_executable-3.9
> ./build/termpair  # error is expected but nothing happens

after

> nox -s build_executable-3.9
> ./build/termpair  # error is expected
usage: termpair [-h] [--version] {share,serve} ...
termpair: error: the following arguments are required: command

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cs01/termpair/pull/84 **Author:** [@cs01](https://github.com/cs01) **Created:** 8/23/2021 **Status:** ✅ Merged **Merged:** 8/23/2021 **Merged by:** [@cs01](https://github.com/cs01) **Base:** `master` ← **Head:** `cs01/require-command` --- ### 📝 Commits (1) - [`ea0d406`](https://github.com/cs01/termpair/commit/ea0d406dbb1d6a03d82245ad92892169d86905d8) require subparser command ### 📊 Changes **5 files changed** (+9 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -0) 📝 `noxfile.py` (+3 -3) 📝 `termpair/constants.py` (+1 -1) 📝 `termpair/frontend_src/src/constants.ts` (+1 -1) 📝 `termpair/main.py` (+1 -1) </details> ### 📄 Description  * [x] I have added an entry to `CHANGELOG.md` ## Summary of changes Require subcommand so the CLI is not confusing if `serve` or `share` is not entered. Instead of silently exiting successfully and not doing anything, an error is raised to tell the user they need to enter a subcommand. ## Test plan  before ``` > nox -s build_executable-3.9 > ./build/termpair # error is expected but nothing happens ``` after ``` > nox -s build_executable-3.9 > ./build/termpair # error is expected usage: termpair [-h] [--version] {share,serve} ... termpair: error: the following arguments are required: command ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>