[PR #69] [MERGED] replace status effect with function #75

New issue

Closed

opened 2026-03-03 01:21:30 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:21:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cs01/termpair/pull/69
Author: @cs01
Created: 7/24/2021
Status: ✅ Merged
Merged: 7/25/2021
Merged by: @cs01

Base: master ← Head: cs01/set-status-effect

📝 Commits (1)

8d58caa replace status useEffect function

📊 Changes

1 file changed (+22 additions, -19 deletions)

View changed files

📝 termpair/frontend_src/src/App.tsx (+22 -19)

📄 Description

Summary of changes

useEffect for status changes was unnecessary. Replaced with a function that updates the state of status, then calls the status change handler.

Test plan

Tested by running

# cd termpair/frontend_src
yarn build
# cd ../..
nox -s serve
# in new terminal
nox -s share

then interact with browser to induce various states.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cs01/termpair/pull/69 **Author:** [@cs01](https://github.com/cs01) **Created:** 7/24/2021 **Status:** ✅ Merged **Merged:** 7/25/2021 **Merged by:** [@cs01](https://github.com/cs01) **Base:** `master` ← **Head:** `cs01/set-status-effect` --- ### 📝 Commits (1) - [`8d58caa`](https://github.com/cs01/termpair/commit/8d58caa08774efcc8dc2981a317a06765b180866) replace status useEffect function ### 📊 Changes **1 file changed** (+22 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `termpair/frontend_src/src/App.tsx` (+22 -19) </details> ### 📄 Description ## Summary of changes `useEffect` for status changes was unnecessary. Replaced with a function that updates the state of `status`, then calls the status change handler. ## Test plan  Tested by running ``` # cd termpair/frontend_src yarn build # cd ../.. nox -s serve # in new terminal nox -s share ``` then interact with browser to induce various states. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>