[PR #63] [MERGED] fix `this.setState is not a function` regression #69

New issue

Closed

opened 2026-03-03 01:21:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 01:21:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cs01/termpair/pull/63
Author: @cs01
Created: 7/11/2021
Status: ✅ Merged
Merged: 7/11/2021
Merged by: @cs01

Base: master ← Head: cs01/fix-broken-app

📝 Commits (1)

9c16742 fix some bugs

📊 Changes

1 file changed (+21 additions, -20 deletions)

View changed files

📝 termpair/frontend_src/src/App.tsx (+21 -20)

📄 Description

Summary of changes

There was a regression in the typescript migration, and this was overridden. The build still worked, and it resulted in a runtime bug of this.setState is not a function. The automigration defined a new class member variable called setState which overrode React's. This took longer than I care to admit to figure out :)

Test plan

Confirmed browser sharing session works

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cs01/termpair/pull/63 **Author:** [@cs01](https://github.com/cs01) **Created:** 7/11/2021 **Status:** ✅ Merged **Merged:** 7/11/2021 **Merged by:** [@cs01](https://github.com/cs01) **Base:** `master` ← **Head:** `cs01/fix-broken-app` --- ### 📝 Commits (1) - [`9c16742`](https://github.com/cs01/termpair/commit/9c167428847e0da131bb291e1698d21cce21ab4e) fix some bugs ### 📊 Changes **1 file changed** (+21 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `termpair/frontend_src/src/App.tsx` (+21 -20) </details> ### 📄 Description ## Summary of changes There was a regression in the typescript migration, and `this` was overridden. The build still worked, and it resulted in a runtime bug of `this.setState is not a function`. The automigration defined a new class member variable called `setState` which overrode React's. This took longer than I care to admit to figure out :) ## Test plan  Confirmed browser sharing session works --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>