starred/termdash

Fork 0

mirror of https://github.com/mum4k/termdash.git synced 2026-04-27 03:15:55 +03:00

[GH-ISSUE #92] LineChart should not anchor the Y axis at zero #60

New issue

Closed

opened 2026-03-03 16:22:01 +03:00 by kerem · 6 comments

kerem commented

2026-03-03 16:22:01 +03:00

Owner

Originally created by @mum4k on GitHub (Jan 26, 2019).
Original GitHub issue: https://github.com/mum4k/termdash/issues/92

Originally assigned to: @mum4k on GitHub.

This loses precision when there are only higher positive values.

The min on the Y axis should be equal to the lowest provided value.

Originally created by @mum4k on GitHub (Jan 26, 2019). Original GitHub issue: https://github.com/mum4k/termdash/issues/92 Originally assigned to: @mum4k on GitHub. This loses precision when there are only higher positive values. The min on the Y axis should be equal to the lowest provided value.

kerem

2026-03-03 16:22:01 +03:00

closed this issue
added the
bug
label

kerem commented

2026-03-03 16:22:02 +03:00

Author

Owner

@mum4k commented on GitHub (Jan 26, 2019):

This is now fixed in the devel branch and will be in the next release.

@mum4k commented on GitHub (Jan 26, 2019): This is now fixed in the devel branch and will be in the next release.

kerem commented

2026-03-03 16:22:03 +03:00

Author

Owner

@activeshadow commented on GitHub (Jan 27, 2019):

This worked great @mum4k thanks!

@activeshadow commented on GitHub (Jan 27, 2019): This worked great @mum4k thanks! ![image](https://user-images.githubusercontent.com/9335331/51794318-5152d880-218d-11e9-9474-bc5412bf8e83.png)

kerem commented

2026-03-03 16:22:03 +03:00

Author

Owner

@activeshadow commented on GitHub (Jan 27, 2019):

@mum4k perhaps make it an option that can be passed to the line chart? Some people may still want it anchored at 0... especially ones already using it for that purpose.

@activeshadow commented on GitHub (Jan 27, 2019): @mum4k perhaps make it an option that can be passed to the line chart? Some people may still want it anchored at 0... especially ones already using it for that purpose.

kerem commented

2026-03-03 16:22:03 +03:00

Author

Owner

@mum4k commented on GitHub (Jan 27, 2019):

Thanks for the screenshot @activeshadow, glad to see this working.

That is a valid point, we can add an option to control this behaviour. I wonder which of the two should be the default. Looking at how linecharts in spreadsheets behave - they anchor at zero by default. Would you be ok with that being the default behaviour and an option to remove the zero-anchor?

That would make this change backward compatible. Let me know what you think.

@mum4k commented on GitHub (Jan 27, 2019): Thanks for the screenshot @activeshadow, glad to see this working. That is a valid point, we can add an option to control this behaviour. I wonder which of the two should be the default. Looking at how linecharts in spreadsheets behave - they anchor at zero by default. Would you be ok with that being the default behaviour and an option to remove the zero-anchor? That would make this change backward compatible. Let me know what you think.

kerem commented

2026-03-03 16:22:03 +03:00

Author

Owner

@activeshadow commented on GitHub (Jan 27, 2019):

@mum4k having it be an option and making the default value be anchored at zero so the change is backwards compatible sounds great! Thanks!

@activeshadow commented on GitHub (Jan 27, 2019): @mum4k having it be an option and making the default value be anchored at zero so the change is backwards compatible sounds great! Thanks!

kerem commented

2026-03-03 16:22:03 +03:00

Author

Owner

@mum4k commented on GitHub (Jan 27, 2019):

PR #96 is now merged into the devel branch. It adds a new linechart.YAxisAdaptive() option. Please give it a try and let me know if something doesn't work as expected.

Thanks again for pointing out that this was going to introduce a backward-incompatible change.

@mum4k commented on GitHub (Jan 27, 2019): PR #96 is now merged into the devel branch. It adds a new linechart.YAxisAdaptive() option. Please give it a try and let me know if something doesn't work as expected. Thanks again for pointing out that this was going to introduce a backward-incompatible change.