[GH-ISSUE #83] Cleanup code issues on go report card #58

Closed
opened 2026-03-03 16:22:01 +03:00 by kerem · 1 comment
Owner

Originally created by @mum4k on GitHub (Jan 22, 2019).
Original GitHub issue: https://github.com/mum4k/termdash/issues/83

https://goreportcard.com/report/github.com/mum4k/termdash

Note: not all of the gocyclo issues should be cleaned up, some functions need to have those switch statements with many cases (like selecting a character). Similarly we don't really want to shorten tests. So the gocyclo category needs judgement.

The other categories are straightforward.

Originally created by @mum4k on GitHub (Jan 22, 2019). Original GitHub issue: https://github.com/mum4k/termdash/issues/83 https://goreportcard.com/report/github.com/mum4k/termdash Note: not all of the gocyclo issues should be cleaned up, some functions need to have those switch statements with many cases (like selecting a character). Similarly we don't really want to shorten tests. So the gocyclo category needs judgement. The other categories are straightforward.
Author
Owner

@nilathedragon commented on GitHub (Jan 22, 2019):

I've created a pull-request #84 which fixes all except the go-cyclo errors

<!-- gh-comment-id:456590832 --> @nilathedragon commented on GitHub (Jan 22, 2019): I've created a pull-request #84 which fixes all except the go-cyclo errors
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/termdash#58
No description provided.