mirror of
https://github.com/mum4k/termdash.git
synced 2026-04-27 03:15:55 +03:00
[GH-ISSUE #132] Looks like we have an off-by-one bug on the graph width calculation in LineChart #84
Labels
No labels
bug
cleanup
enhancement
enhancement
enhancement
good first issue
help wanted
help wanted
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/termdash#84
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mum4k on GitHub (Feb 18, 2019).
Original GitHub issue: https://github.com/mum4k/termdash/issues/132
Specifically here:
github.com/mum4k/termdash@34fe013ca6/widgets/linechart/axes/axes.go (L176)This statement makes the last cell inaccessible. Needs investigation though, as the rest of the infra and the unit test seem to account for this.
No serious impact, this will result in a larger than necessary gap (one cell) in some scenarios when drawing the line chart series.
@mum4k commented on GitHub (Apr 27, 2019):
Closing this until we see impact that would justify a fix.