[GH-ISSUE #132] Looks like we have an off-by-one bug on the graph width calculation in LineChart #84

Closed
opened 2026-03-03 16:22:13 +03:00 by kerem · 1 comment
Owner

Originally created by @mum4k on GitHub (Feb 18, 2019).
Original GitHub issue: https://github.com/mum4k/termdash/issues/132

Specifically here:

github.com/mum4k/termdash@34fe013ca6/widgets/linechart/axes/axes.go (L176)

This statement makes the last cell inaccessible. Needs investigation though, as the rest of the infra and the unit test seem to account for this.

No serious impact, this will result in a larger than necessary gap (one cell) in some scenarios when drawing the line chart series.

Originally created by @mum4k on GitHub (Feb 18, 2019). Original GitHub issue: https://github.com/mum4k/termdash/issues/132 Specifically here: https://github.com/mum4k/termdash/blob/34fe013ca66df93df75868f43386db104c9f1700/widgets/linechart/axes/axes.go#L176 This statement makes the last cell inaccessible. Needs investigation though, as the rest of the infra and the unit test seem to account for this. No serious impact, this will result in a larger than necessary gap (one cell) in some scenarios when drawing the line chart series.
kerem 2026-03-03 16:22:13 +03:00
Author
Owner

@mum4k commented on GitHub (Apr 27, 2019):

Closing this until we see impact that would justify a fix.

<!-- gh-comment-id:487261655 --> @mum4k commented on GitHub (Apr 27, 2019): Closing this until we see impact that would justify a fix.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/termdash#84
No description provided.