[PR #219] [CLOSED] dw/fork #264

New issue

Closed

opened 2026-03-03 16:23:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:23:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mum4k/termdash/pull/219
Author: @donaldww
Created: 7/9/2019
Status: ❌ Closed

Base: master ← Head: dw/fork

📝 Commits (5)

c31957d Add go.mod
809089a Update for compatibility with go.mod
8342421 Run go mod tidy
fc6a0d0 Source file cleanup
d70b7da Update go.mod

📊 Changes

137 files changed (+662 additions, -627 deletions)

View changed files

📝 container/container.go (+6 -6)
📝 container/container_test.go (+15 -15)
📝 container/draw.go (+5 -5)
📝 container/draw_test.go (+9 -9)
📝 container/focus.go (+3 -3)
📝 container/focus_test.go (+7 -7)
📝 container/grid/grid.go (+2 -2)
📝 container/grid/grid_test.go (+13 -13)
📝 container/options.go (+5 -5)
📝 container/traversal_test.go (+2 -2)
➕ go.mod (+9 -0)
➕ go.sum (+6 -0)
📝 internal/alignfor/alignfor.go (+3 -3)
📝 internal/alignfor/alignfor_test.go (+2 -1)
📝 internal/area/area.go (+1 -1)
📝 internal/attrrange/attrrange_test.go (+2 -1)
📝 internal/button/button.go (+2 -2)
📝 internal/button/button_test.go (+2 -2)
📝 internal/canvas/braille/braille.go (+3 -3)
📝 internal/canvas/braille/braille_test.go (+6 -5)

...and 80 more files

📄 Description

This branch is compatible with Go Modules, which will be the default dependency management system upon release of go 1.13. It already works with go 1.12 by setting GO111MODULE=on.

Although there are many files touched, it really boils down to adding a go.mod file in the root directory, and eliminating "github.com/mum4k/" from all of the import statements. Thus the number of modified files.

The advantage of having the local dependancies sourced from within the directory structure is that when you're changing any packages or examples, test compiles use those locally changed files, rather than importing the unaltered versions on github.

I ran all of the tests, and they all (2499) passed. Also compiled and ran the example programs.

Cheers, DW

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mum4k/termdash/pull/219 **Author:** [@donaldww](https://github.com/donaldww) **Created:** 7/9/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dw/fork` --- ### 📝 Commits (5) - [`c31957d`](https://github.com/mum4k/termdash/commit/c31957d684d44e8bc979a2a1245c2adb5e6b2d71) Add go.mod - [`809089a`](https://github.com/mum4k/termdash/commit/809089ac46ac930ccc0c500b445ff0a47509ade7) Update for compatibility with go.mod - [`8342421`](https://github.com/mum4k/termdash/commit/8342421ad05e054baa94afcfe494267ef266fc80) Run go mod tidy - [`fc6a0d0`](https://github.com/mum4k/termdash/commit/fc6a0d0dd6c05cdf371fcbfd6afb00126d045043) Source file cleanup - [`d70b7da`](https://github.com/mum4k/termdash/commit/d70b7da98bdaa48ff38198f478f42ba85d29822f) Update go.mod ### 📊 Changes **137 files changed** (+662 additions, -627 deletions) <details> <summary>View changed files</summary> 📝 `container/container.go` (+6 -6) 📝 `container/container_test.go` (+15 -15) 📝 `container/draw.go` (+5 -5) 📝 `container/draw_test.go` (+9 -9) 📝 `container/focus.go` (+3 -3) 📝 `container/focus_test.go` (+7 -7) 📝 `container/grid/grid.go` (+2 -2) 📝 `container/grid/grid_test.go` (+13 -13) 📝 `container/options.go` (+5 -5) 📝 `container/traversal_test.go` (+2 -2) ➕ `go.mod` (+9 -0) ➕ `go.sum` (+6 -0) 📝 `internal/alignfor/alignfor.go` (+3 -3) 📝 `internal/alignfor/alignfor_test.go` (+2 -1) 📝 `internal/area/area.go` (+1 -1) 📝 `internal/attrrange/attrrange_test.go` (+2 -1) 📝 `internal/button/button.go` (+2 -2) 📝 `internal/button/button_test.go` (+2 -2) 📝 `internal/canvas/braille/braille.go` (+3 -3) 📝 `internal/canvas/braille/braille_test.go` (+6 -5) _...and 80 more files_ </details> ### 📄 Description This branch is compatible with Go Modules, which will be the default dependency management system upon release of go 1.13. It already works with go 1.12 by setting GO111MODULE=on. Although there are many files touched, it really boils down to adding a go.mod file in the root directory, and eliminating "github.com/mum4k/" from all of the import statements. Thus the number of modified files. The advantage of having the local dependancies sourced from within the directory structure is that when you're changing any packages or examples, test compiles use those locally changed files, rather than importing the unaltered versions on github. I ran all of the tests, and they all (2499) passed. Also compiled and ran the example programs. Cheers, DW --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>