[PR #145] [MERGED] Fixing the width of characters whose context is known. #219

New issue

Closed

opened 2026-03-03 16:23:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:23:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mum4k/termdash/pull/145
Author: @mum4k
Created: 2/22/2019
Status: ✅ Merged
Merged: 2/22/2019
Merged by: @mum4k

Base: devel ← Head: runewidth

📝 Commits (5)

43e15c3 A wrapper over the external runewidth package.
793925f Migrating all calls to the runewidth wrapper.
3b2abce Defining exceptions to the East Asian ambiguous cell width.
102e098 Updating CHANGELOG.
f1a83ec Adding licences.

📊 Changes

12 files changed (+275 additions, -9 deletions)

View changed files

📝 CHANGELOG.md (+2 -0)
📝 align/align.go (+1 -1)
📝 cell/cell.go (+1 -1)
➕ cell/runewidth/runewidth.go (+98 -0)
➕ cell/runewidth/runewidth_test.go (+166 -0)
📝 draw/line_style.go (+1 -1)
📝 draw/text.go (+1 -1)
📝 widgets/donut/donut.go (+1 -1)
📝 widgets/gauge/gauge.go (+1 -1)
📝 widgets/sparkline/sparks.go (+1 -1)
📝 widgets/text/line_scanner.go (+1 -1)
📝 widgets/text/line_trim.go (+1 -1)

📄 Description

These are characters used internally by termdash to draw boxes, indicate need to resize or scroll, etc.

Ensuring these are always considered half-width runes, even though they might be ambiguous in some locales.

Fixes #144

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mum4k/termdash/pull/145 **Author:** [@mum4k](https://github.com/mum4k) **Created:** 2/22/2019 **Status:** ✅ Merged **Merged:** 2/22/2019 **Merged by:** [@mum4k](https://github.com/mum4k) **Base:** `devel` ← **Head:** `runewidth` --- ### 📝 Commits (5) - [`43e15c3`](https://github.com/mum4k/termdash/commit/43e15c302e1afc96b8fb34d79f07b981db5f7ae6) A wrapper over the external runewidth package. - [`793925f`](https://github.com/mum4k/termdash/commit/793925feb872f6b8cf96570642eb6c532ebcb69d) Migrating all calls to the runewidth wrapper. - [`3b2abce`](https://github.com/mum4k/termdash/commit/3b2abce00bd984c9258cce295fedbd7642f62c24) Defining exceptions to the East Asian ambiguous cell width. - [`102e098`](https://github.com/mum4k/termdash/commit/102e098dac12aaa45abf4dc7907a66a64658aec8) Updating CHANGELOG. - [`f1a83ec`](https://github.com/mum4k/termdash/commit/f1a83ecd223d543b8e049a6abacfeb0c9ea0581c) Adding licences. ### 📊 Changes **12 files changed** (+275 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+2 -0) 📝 `align/align.go` (+1 -1) 📝 `cell/cell.go` (+1 -1) ➕ `cell/runewidth/runewidth.go` (+98 -0) ➕ `cell/runewidth/runewidth_test.go` (+166 -0) 📝 `draw/line_style.go` (+1 -1) 📝 `draw/text.go` (+1 -1) 📝 `widgets/donut/donut.go` (+1 -1) 📝 `widgets/gauge/gauge.go` (+1 -1) 📝 `widgets/sparkline/sparks.go` (+1 -1) 📝 `widgets/text/line_scanner.go` (+1 -1) 📝 `widgets/text/line_trim.go` (+1 -1) </details> ### 📄 Description These are characters used internally by termdash to draw boxes, indicate need to resize or scroll, etc. Ensuring these are always considered half-width runes, even though they might be ambiguous in some locales. Fixes #144 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>