[PR #16] [MERGED] colossal pull request #10

New issue

Closed

opened 2026-03-07 13:55:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-07 13:55:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/alexk218/tagify/pull/16
Author: @alexk218
Created: 9/2/2025
Status: ✅ Merged
Merged: 9/2/2025
Merged by: @alexk218

Base: main ← Head: refactor/cleanup-project

📝 Commits (10+)

45b1ae1 remove render logic in app.tsx -> everything inline
05eeb0d remove unnecessary handler - calls dismissUpdate directly
832efb6 REMOVE ALL UNUSED CSS STYLES
82c49e1 remove unused css contd
10a2131 refactored tag filter logic. doesn't unnecessarily parse fullTagId - uses it directly. + method renaming for clarity
31ebbb7 add purgecss command to package.json scripts
61bcf88 ADD VITEST TESTS - WIP
3276178 fix play track! always plays tracks - doesn't add to queue - gracefully handles local files too (using dummy Spotify track)
294e3ea improve tests - 2 files failing (smart-playlist-edge-cases + TagSelector)
ad197bd smart playlist validation on load

📊 Changes

52 files changed (+9197 additions, -3969 deletions)

View changed files

📝 .gitignore (+2 -0)
📝 install.sh (+1 -1)
📝 package-lock.json (+74 -3)
📝 package.json (+8 -2)
➕ scripts/setup-tests.js (+205 -0)
📝 src/app.module.css (+0 -32)
📝 src/app.tsx (+226 -271)
📝 src/components/CreatePlaylistModal.tsx (+2 -1)
📝 src/components/DataManager.module.css (+2 -139)
📝 src/components/DataManager.tsx (+15 -8)
➕ src/components/DiscoverySurvey.module.css (+342 -0)
➕ src/components/DiscoverySurvey.tsx (+216 -0)
📝 src/components/ExportPanel.module.css (+0 -126)
📝 src/components/InfoModal.module.css (+21 -337)
📝 src/components/InfoModal.tsx (+475 -232)
📝 src/components/LocalTracksModal.module.css (+0 -16)
📝 src/components/MultiTrackDetails.module.css (+193 -57)
📝 src/components/MultiTrackDetails.tsx (+504 -371)
📝 src/components/PlaylistSettings.module.css (+0 -51)
📝 src/components/RefreshModal.module.css (+0 -8)

...and 32 more files

📄 Description

MAINLY: Can apply star ratings & energy ratings in bulk.
Style changes across the app - better icons.
Added documentation to custom hooks (TypeDoc).
major refactoring across whole project - cleaned up duplicate code - removed unused css classes - created useful abstractions - etc etc.
Fix playTrack in trackService - actually plays tracks - doesn't just add to queue.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/alexk218/tagify/pull/16 **Author:** [@alexk218](https://github.com/alexk218) **Created:** 9/2/2025 **Status:** ✅ Merged **Merged:** 9/2/2025 **Merged by:** [@alexk218](https://github.com/alexk218) **Base:** `main` ← **Head:** `refactor/cleanup-project` --- ### 📝 Commits (10+) - [`45b1ae1`](https://github.com/alexk218/tagify/commit/45b1ae1ac57dbd08b7e771d7b9c81c78b5797312) remove render logic in app.tsx -> everything inline - [`05eeb0d`](https://github.com/alexk218/tagify/commit/05eeb0d1c0171a1e308cd20d32ac45106b92ea73) remove unnecessary handler - calls dismissUpdate directly - [`832efb6`](https://github.com/alexk218/tagify/commit/832efb6a9966e828957a073fe6f79de6e733e742) REMOVE ALL UNUSED CSS STYLES - [`82c49e1`](https://github.com/alexk218/tagify/commit/82c49e1b891150a42678275d572fbc35e66300a4) remove unused css contd - [`10a2131`](https://github.com/alexk218/tagify/commit/10a21313764c3dc3a3315a12b1e02f95ee3568f4) refactored tag filter logic. doesn't unnecessarily parse fullTagId - uses it directly. + method renaming for clarity - [`31ebbb7`](https://github.com/alexk218/tagify/commit/31ebbb7ad658726166bf3a9df5300be519db3dc0) add purgecss command to package.json scripts - [`61bcf88`](https://github.com/alexk218/tagify/commit/61bcf885cc9181f830c7dad64d4641eeb42c8dbe) ADD VITEST TESTS - WIP - [`3276178`](https://github.com/alexk218/tagify/commit/32761780fd56f600349e245c825b51faeeb49eca) fix play track! always plays tracks - doesn't add to queue - gracefully handles local files too (using dummy Spotify track) - [`294e3ea`](https://github.com/alexk218/tagify/commit/294e3ea3ea514382a1380c479313a5c5418cf4a3) improve tests - 2 files failing (smart-playlist-edge-cases + TagSelector) - [`ad197bd`](https://github.com/alexk218/tagify/commit/ad197bd8fa0c4d912d0dddba87a120b77d4cabf4) smart playlist validation on load ### 📊 Changes **52 files changed** (+9197 additions, -3969 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+2 -0) 📝 `install.sh` (+1 -1) 📝 `package-lock.json` (+74 -3) 📝 `package.json` (+8 -2) ➕ `scripts/setup-tests.js` (+205 -0) 📝 `src/app.module.css` (+0 -32) 📝 `src/app.tsx` (+226 -271) 📝 `src/components/CreatePlaylistModal.tsx` (+2 -1) 📝 `src/components/DataManager.module.css` (+2 -139) 📝 `src/components/DataManager.tsx` (+15 -8) ➕ `src/components/DiscoverySurvey.module.css` (+342 -0) ➕ `src/components/DiscoverySurvey.tsx` (+216 -0) 📝 `src/components/ExportPanel.module.css` (+0 -126) 📝 `src/components/InfoModal.module.css` (+21 -337) 📝 `src/components/InfoModal.tsx` (+475 -232) 📝 `src/components/LocalTracksModal.module.css` (+0 -16) 📝 `src/components/MultiTrackDetails.module.css` (+193 -57) 📝 `src/components/MultiTrackDetails.tsx` (+504 -371) 📝 `src/components/PlaylistSettings.module.css` (+0 -51) 📝 `src/components/RefreshModal.module.css` (+0 -8) _...and 32 more files_ </details> ### 📄 Description **MAINLY: Can apply star ratings & energy ratings in bulk.** Style changes across the app - better icons. Added documentation to custom hooks (TypeDoc). major refactoring across whole project - cleaned up duplicate code - removed unused css classes - created useful abstractions - etc etc. Fix playTrack in trackService - actually plays tracks - doesn't just add to queue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-07 13:55:41 +03:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/tagify#10

No description provided.

Rows
Columns