[GH-ISSUE #1345] Problematic apostrophe. #838

Closed
opened 2026-03-02 02:19:23 +03:00 by kerem · 4 comments
Owner

Originally created by @cm-slu on GitHub (Nov 8, 2022).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/1345

Server Info (please complete the following information):

  • OS: [Ubuntu 20.04]
  • Browser: [chrome]
  • RMM Version : Latest

Installation Method:

  • Standard
  • Docker

Agent Info (please complete the following information):

  • Agent version (as shown in the 'Summary' tab of the agent from web UI):2.4.1
  • Agent OS: [e.g. Win 10 v2004, Server 2012 R2]: All Windows

Describe the bug
The terminator ' is missing from the string.
+ CategoryInfo : ParserError: (:) [], ParentContainsErrorRecordEx
ception
+ FullyQualifiedErrorId : TerminatorExpectedAtEndOfString

To Reproduce
Steps to reproduce the behavior:

  1. In description of agent add apostrophe ( ' )
  2. In script add an argument agent.description

Screenshots
image

Originally created by @cm-slu on GitHub (Nov 8, 2022). Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/1345 **Server Info (please complete the following information):** - OS: [Ubuntu 20.04] - Browser: [chrome] - RMM Version : Latest **Installation Method:** - [X] Standard - [ ] Docker **Agent Info (please complete the following information):** - Agent version (as shown in the 'Summary' tab of the agent from web UI):2.4.1 - Agent OS: [e.g. Win 10 v2004, Server 2012 R2]: All Windows **Describe the bug** The terminator ' is missing from the string. + CategoryInfo : ParserError: (:) [], ParentContainsErrorRecordEx ception + FullyQualifiedErrorId : TerminatorExpectedAtEndOfString **To Reproduce** Steps to reproduce the behavior: 1. In description of agent add apostrophe ( ' ) 2. In script add an argument agent.description **Screenshots** ![image](https://user-images.githubusercontent.com/82769965/200615910-78935fe7-44b0-4f96-b515-55d3a885c7b6.png)
kerem 2026-03-02 02:19:23 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@silversword411 commented on GitHub (Dec 23, 2022):

Should there be a test in the repo for testing chars in fields?

Should probably have input validation everywhere for all chars...like null space chars and all the other weird chars

<!-- gh-comment-id:1364412557 --> @silversword411 commented on GitHub (Dec 23, 2022): Should there be a test in the repo for testing chars in fields? Should probably have input validation everywhere for all chars...like null space chars and all the other weird chars
Author
Owner

@wh1te909 commented on GitHub (Dec 24, 2022):

@cm-slu I have pushed a fix please see the linked commit and manually make the change on your server and then sudo systemctl restart rmm and please test it out and let me know if it works

@silversword411 a unit test would not catch it, need an end to end test to run on a real agent

<!-- gh-comment-id:1364418448 --> @wh1te909 commented on GitHub (Dec 24, 2022): @cm-slu I have pushed a fix please see the linked commit and manually make the change on your server and then `sudo systemctl restart rmm` and please test it out and let me know if it works @silversword411 a unit test would not catch it, need an end to end test to run on a real agent
Author
Owner

@cm-slu commented on GitHub (Jan 9, 2023):

Hello, and thank you very much for the correction.

I prefer to wait for the release, I'm not sure I know how to patch the version.

<!-- gh-comment-id:1375935831 --> @cm-slu commented on GitHub (Jan 9, 2023): Hello, and thank you very much for the correction. I prefer to wait for the release, I'm not sure I know how to patch the version.
Author
Owner

@wh1te909 commented on GitHub (Jan 19, 2023):

@cm-slu it's released now

<!-- gh-comment-id:1396270997 --> @wh1te909 commented on GitHub (Jan 19, 2023): @cm-slu it's released now
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tacticalrmm#838
No description provided.