mirror of
https://github.com/amidaware/tacticalrmm.git
synced 2026-04-26 23:15:57 +03:00
[GH-ISSUE #1345] Problematic apostrophe. #838
Labels
No labels
In Process
bug
bug
dev-triage
documentation
duplicate
enhancement
fixed
good first issue
help wanted
integration
invalid
pull-request
question
requires agent update
security
ui tweak
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tacticalrmm#838
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cm-slu on GitHub (Nov 8, 2022).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/1345
Server Info (please complete the following information):
Installation Method:
Agent Info (please complete the following information):
Describe the bug
The terminator ' is missing from the string.
+ CategoryInfo : ParserError: (:) [], ParentContainsErrorRecordEx
ception
+ FullyQualifiedErrorId : TerminatorExpectedAtEndOfString
To Reproduce
Steps to reproduce the behavior:
Screenshots

@silversword411 commented on GitHub (Dec 23, 2022):
Should there be a test in the repo for testing chars in fields?
Should probably have input validation everywhere for all chars...like null space chars and all the other weird chars
@wh1te909 commented on GitHub (Dec 24, 2022):
@cm-slu I have pushed a fix please see the linked commit and manually make the change on your server and then
sudo systemctl restart rmmand please test it out and let me know if it works@silversword411 a unit test would not catch it, need an end to end test to run on a real agent
@cm-slu commented on GitHub (Jan 9, 2023):
Hello, and thank you very much for the correction.
I prefer to wait for the release, I'm not sure I know how to patch the version.
@wh1te909 commented on GitHub (Jan 19, 2023):
@cm-slu it's released now