mirror of
https://github.com/amidaware/tacticalrmm.git
synced 2026-04-26 15:05:57 +03:00
[GH-ISSUE #978] Cannot connect to MeshCentral: iframe is simply white (incorrect gotonode?) #593
Labels
No labels
In Process
bug
bug
dev-triage
documentation
duplicate
enhancement
fixed
good first issue
help wanted
integration
invalid
pull-request
question
requires agent update
security
ui tweak
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tacticalrmm#593
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @fts-tmassey on GitHub (Feb 18, 2022).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/978
Tactical RMM (TRMM) Server:
Ubuntu 20.04
Browser: Firefox 97.0
TRMM Version 0.11.3
Installation: Standard
External MeshCentral (MC) Server:
Ubuntu 20.04
MC Version 0.9.83
Agent Info:
Version: 1.8.0
MeshCentral Agent: 0.2.1.3 (as shown in MeshAgent.exe Properties)
Agent OS: Windows 10 Pro, 64 bit v21H2
Describe the bug
When I click on either Take Control or Actions/Remote Background, the iframe for the MeshCentral component is simply a white (empty) box.
To Reproduce
Log into TRMM
Select an agent
Click on Take Control
Get a new tab that contains the thin Agent Status header, but the MC iframe below is completely white. Same happens with Remote Background.
Expected behavior
I should get the MC remote control content in the iframe.
Screenshots
I will add if needed, but it's a white box... :)
Additional context
In digging into this, I looked at the URL for the iframe. The information is sanitized and reproduced here:
https://mc.example.com/?login=&gotonode=95BC0609AE7C1D04347BB4FBDF6618A03A16B5BB71BDCDD3C8E051242B07E9E1826739AFE7F8919843EFF54E9A4924B50&viewmode=11&hide=31
However, when I log into MC as the same user and open the page for that agent, here is the URL:
https://mc.example.com/?viewmode=10&gotonode=lbwGCa58HQQ0e7T732YYoDoWtbtxvc3TyOBRJCsH6eGCZzmv5$iRmEPv9U6aSSS1
I notice that the gotonode parameters are completely different. it seems that the TRMM URL might use a different form of encoding than the direct-from-MC example, so I'm not certain if they decode to the same thing or not; however, if I cut and paste the MC gotonode into the TRMM URL, it works correctly.
Is it possible that the TRMM agent is not using the correct ID for MC?
To attempt to diagnose this further, I have done the following, none of which changed anything:
= Searched for "MeshAgent.exe" on the entire client computer: the only one found was in "C:\Program Files\Mesh Agent"
= Uninstalled the TRMM agent from the client (using Add/Remove Programs)
= Confirmed that "C:\Program Files\TacticalAgent" and "C:\Program Files\Mesh Agent" were removed.
= Reinstalled the TRMM agent
= Attempted to use the "Take Control" function: no change.
= Repeated all of the above steps but using the "Remove Agent" action instead of manual uninstall.
= Used Actions/Agent Recovery/Mesh Agent
= Rebooted TRMM server
= Rebooted MC server
This is a new setup this week. Earlier in the week, the "Take Control" button worked fine, but sometime over the last few days it stopped. I do not recall making any configuration changes.
The MeshCentral User ID and Login token seem to be correct. If I were to browse "https://mc.example.com" directly, the MC dashboard opens, logged in as the MC user I put into TRMM. If I then log out from MC there and use TRRM to Take Control, I still get the white box, but if I browse "https://mc.example.com" again, I'm taken to the MC main dashboard no problem. So it seems to be logging in successfully.
(That leads to an unrelated concern: does this mean that my users will be able to bypass the user permissions controls in TRMM simply by connecting to a client they can connect to, then open MC directly to get access to everything that TRMM can manage?)
Please let me know what additional information or testing I can provide to you. Thank you very much!
@dinger1986 commented on GitHub (Feb 18, 2022):
So the agent is available in mesh and you can connect directly to it? Is this a standard install nothing fancy with proxy's etc?
Also yes it does mean you can get round the user controls in tactical using mesh
@fts-tmassey commented on GitHub (Feb 18, 2022):
That is correct: the agent is available in Mesh, I can remote control, get a file list, etc. Everything is working 100% correctly in Mesh. Everything that is provided by the TRMM agent seems to be working 100% correctly as well: when I use the Remote Background action, I can use the Services tab and see services just fine; but the Terminal and File Browser tabs simply have a white iframe.
The agent PC is a completely standard Windows 10 PC. Because this is a test environment, I only have the agent on two PC's right now, and the problem happens with both. There are no proxy servers ,etc. involved. The servers are cloud-based VM's and the PC's are behind a Ubiquiti EdgeRouter X NAT firewall, with no outbound restrictions, etc.
ETA: I re-read your message about user controls: I originally read it as a question, and it seems you meant it as a statement. To rephrase what I think you are saying: it is a known issue that any TRMM user will have 100% total access to 100% of the PC's that the TRMM user in MC has access to, simply by browsing the MC URL. Assuming that this is the case, I will look and see if there is a security issue for that: that's not cool at all... :) The below text is kept for reference, but you don't need it:
As for the getting around controls part: I haven't investigated that yet, so I may be missing something, and I don't want to derail this issue. I was just really surprised that while trying to debug the iframe issue I browsed my bare MC URL and it took me directly into the MC dashboard as the unique Full Admin user I used for TRMM without me entering a user ID or password. To make sure there wasn't anything stale, I logged out of MC and reloaded the URL: I got the login prompt again. But once I used TRMM to try to connect to a client, if I go to the bare MC URL, I go right back into the dashboard as the TRMM user, with Full Admin rights.
If I can do that, can't anyone else who has access to TRMM, even if they've been limited within TRMM to only a single PC? And if so, can't they then control any PC that that Full Admin user has in MC? That would very much not be my intention: some of my TRMM users only have access to certain clients. But like I said, I have not fully investigated this. If you know that I'm missing something and can tell me in a sentence, great, I won't waste your time with a second issue. But if not, I will happily create a separate issue if I find out that I can use that to gain control over a PC that a given TRMM user should not be able to.
@dinger1986 commented on GitHub (Feb 18, 2022):
Did this used to work?
This has always been the case as mesh is used only for remote. You can use another remote viewer or give users direct access to a machine with mesh
@fts-tmassey commented on GitHub (Feb 18, 2022):
It worked initially, yes. And then something changed, and it does not now work. To my knowledge, I made no changes, either to the agent PC's (the problem happens with multiple PC's), nor to either the TRMM server nor the MC server. I barely looked at the thing in the last couple of days, and like I said it's a new, test install so I'm the only one with access to it.